conflict issues (#6)#7
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| try: | ||
| from .stability import compute_stability_metrics | ||
| except ImportError: | ||
| from stability import compute_stability_metrics |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88e78c6cb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| class StabilityRequest(BaseModel): | ||
| sequence: str = Field(..., description="Amino-acid sequence (single letter codes)") |
There was a problem hiding this comment.
This change imports compute_stability_metrics() and adds StabilityRequest/StabilityResponse, but backend/main.py still registers no @app.post("/api/stability") handler—I checked backend.main.app.routes, and only /api/health, /api/predict, /api/uniprot/*, and /api/analyze are exposed. Any client following the new backend docs or expecting the advertised stability screen will get a 404, so the feature added here is unreachable.
Useful? React with 👍 / 👎.
| class SolubilityRequest(BaseModel): | ||
| sequence: str = Field(..., min_length=10, max_length=2000, description="Amino-acid sequence (single letter codes)") |
There was a problem hiding this comment.
These new solubility DTOs are never used by a route, and there is still no @app.post("/api/solubility") or @app.get("/api/solubility/search") anywhere in backend/main.py (repo search only finds those paths in the new docs). As a result, every request to the documented solubility API returns 404 and the new backend capability is unavailable.
Useful? React with 👍 / 👎.
Siddharthakhandelwal
force-pushed
the
Rudraksh
branch
from
88e78c6 to
dfd112e
Compare
1 participant
started the work on backend
Add confidence metrics module and update requirements
added the docs and rearranged the files
Add /api/stability endpoint with stability models and tighten sequence validation (Add /api/stability endpoint with stability models and tighten sequence validation #5)
Remove issue markdown file and provide issue text inline
Modularize stability computation with isolated service logic
Add detailed backend feature and architecture docs
Fix stability request length validation after cleaning