Skip to content

fix(ci): make Windows cross-platform tests path-safe#714

Merged
rafaelscosta merged 1 commit intomainfrom
fix/windows-cross-platform-ci-20260508
May 8, 2026
Merged

fix(ci): make Windows cross-platform tests path-safe#714
rafaelscosta merged 1 commit intomainfrom
fix/windows-cross-platform-ci-20260508

Conversation

@rafaelscosta
Copy link
Copy Markdown
Collaborator

@rafaelscosta rafaelscosta commented May 8, 2026

Summary

  • Fixes the post-merge Windows cross-platform CI failure from main after chore(security): refresh actions and dependency locks #708.
  • Resolves Pro updater project roots with native paths before reading package/core metadata.
  • Makes Bob orchestrator and delegation CLI tests compare paths portably across POSIX/Windows.
  • Updates generated install/entity metadata for the changed core file.

Validation

  • npx jest --runInBand tests/core/orchestration/bob-orchestrator.test.js tests/pro/pro-updater.test.js tests/cli/aiox-delegate.test.js
  • npm run lint
  • npm run typecheck
  • npm run test:ci
  • npm audit --omit=dev --json: 0 vulnerabilities
  • npm run build: not applicable, script is not defined

Summary by CodeRabbit

  • Bug Fixes

    • Improved path-resolution consistency in core update logic for more reliable file lookups across different project setups.
  • Chores

    • Refreshed registry and install manifest integrity metadata and timestamps.
  • Tests

    • Strengthened tests for cross-platform path handling and standardized sandbox/workdir assertions for more robust CLI and orchestration validation.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aiox-core Ready Ready Preview, Comment May 8, 2026 9:29pm

Request Review

@github-actions github-actions Bot added type: test Test coverage and quality area: core Core framework (.aios-core/core/) area: docs Documentation (docs/) labels May 8, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 47ed2301-2f45-426d-b62d-d0f97fba78ff

📥 Commits

Reviewing files that changed from the base of the PR and between ae20b61 and 10143eb.

📒 Files selected for processing (5)
  • .aiox-core/core/pro/pro-updater.js
  • .aiox-core/data/entity-registry.yaml
  • .aiox-core/install-manifest.yaml
  • tests/cli/aiox-delegate.test.js
  • tests/core/orchestration/bob-orchestrator.test.js
✅ Files skipped from review due to trivial changes (3)
  • tests/cli/aiox-delegate.test.js
  • .aiox-core/data/entity-registry.yaml
  • .aiox-core/install-manifest.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • tests/core/orchestration/bob-orchestrator.test.js
  • .aiox-core/core/pro/pro-updater.js

Walkthrough

This PR normalizes path resolution in the pro-updater module by calling path.resolve() consistently across three functions, adds cross-platform path handling to tests via a portablePath helper, refactors CLI test assertions to use a shared workdir constant, and updates generated manifest files with new checksums and timestamps.

Changes

Path Resolution and Test Updates

Layer / File(s) Summary
Core Path Resolution
.aiox-core/core/pro/pro-updater.js
readProjectPackageJson, buildNodeModulesPackageJsonPath, and getCoreVersion refactored to resolve projectRoot consistently using path.resolve() before constructing filesystem paths.
Cross-Platform Test Helpers
tests/core/orchestration/bob-orchestrator.test.js
Added portablePath utility function that normalizes Windows backslashes to forward slashes for platform-agnostic path assertions.
Test Assertions and Constants
tests/cli/aiox-delegate.test.js
Introduced shared workdir constant (/tmp/work) and updated plan and sandbox assertions to use the variable instead of hardcoded paths.
Generated Manifests & Registry
.aiox-core/install-manifest.yaml, .aiox-core/data/entity-registry.yaml
Manifest generated_at timestamp, install entry hash and size, and registry metadata.lastUpdated, checksum, and lastVerified values updated to reflect code changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

area: cli, area: pro, area: workflows, area: devops

Suggested reviewers

  • Pedrovaleriolopez
  • oalanicolas
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing Windows cross-platform path handling in CI tests and the Pro updater.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-cross-platform-ci-20260508

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

📊 Coverage Report

Coverage report not available

📈 Full coverage report available in Codecov


Generated by PR Automation (Story 6.1)

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 8, 2026
@rafaelscosta rafaelscosta merged commit 3776fc1 into main May 8, 2026
43 checks passed
@rafaelscosta rafaelscosta deleted the fix/windows-cross-platform-ci-20260508 branch May 8, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core framework (.aios-core/core/) area: docs Documentation (docs/) type: test Test coverage and quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant