Skip to content

Improve accessibly of room dashboard#2970

Draft
samuelwei wants to merge 1 commit intodevelopfrom
a11y-room-index
Draft

Improve accessibly of room dashboard#2970
samuelwei wants to merge 1 commit intodevelopfrom
a11y-room-index

Conversation

@samuelwei
Copy link
Collaborator

Fixes #

Type

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

Other information

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 23, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 05b15679-055e-468a-8079-957b2b45fd38

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch a11y-room-index

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.73%. Comparing base (23115e6) to head (a6c14b6).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
resources/js/components/RoomDetailsList.vue 60.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #2970       +/-   ##
==============================================
- Coverage      96.71%   82.73%   -13.99%     
  Complexity      1906     1906               
==============================================
  Files            445      446        +1     
  Lines          12878    12879        +1     
  Branches        2072     2075        +3     
==============================================
- Hits           12455    10655     -1800     
- Misses           423     2224     +1801     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cypress
Copy link

cypress bot commented Mar 23, 2026

PILOS    Run #2884

Run Properties:  status check failed Failed #2884  •  git commit a6c14b6820: Improve accessibly of room dashboard
Project PILOS
Branch Review a11y-room-index
Run status status check failed Failed #2884
Run duration 07m 47s
Commit git commit a6c14b6820: Improve accessibly of room dashboard
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 9
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 612
View all changes introduced in this branch ↗︎

Tests for review

Failed  RoomsViewGeneral.cy.js • 2 failed tests • Frontend tests

View Output

Test Artifacts
Room View general > trigger favorites button Test Replay Screenshots
Room View general > trigger favorites button errors Test Replay Screenshots
Failed  AdminRoomTypesEdit.cy.js • 1 failed test • Frontend tests

View Output

Test Artifacts
Admin room types edit > edit room type Test Replay Screenshots
Failed  RoomsIndex.cy.js • 3 failed tests • Frontend tests

View Output

Test Artifacts
Room Index > check list of rooms and opening room view Test Replay Screenshots
Room Index > trigger favorites button Test Replay Screenshots
Room Index > trigger favorites button errors Test Replay Screenshots
Failed  AdminRoomTypesNew.cy.js • 1 failed test • Frontend tests

View Output

Test Artifacts
Admin room types new > add new room type Test Replay Screenshots
Failed  AdminRoomTypesView.cy.js • 1 failed test • Frontend tests

View Output

Test Artifacts
Admin room types view > check roomTypeView shown correctly Test Replay Screenshots

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant