Skip to content

Add close button to room share popover (screen readers only)#2971

Draft
samuelwei wants to merge 1 commit intodevelopfrom
a11y-add-sr-only-close-button
Draft

Add close button to room share popover (screen readers only)#2971
samuelwei wants to merge 1 commit intodevelopfrom
a11y-add-sr-only-close-button

Conversation

@samuelwei
Copy link
Collaborator

Fixes #

Type

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

Other information

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 23, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 80459425-c4bf-4516-9e33-c6420579c14f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch a11y-add-sr-only-close-button

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.70%. Comparing base (78fe5a7) to head (7620a74).

Files with missing lines Patch % Lines
resources/js/components/RoomShareButton.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2971      +/-   ##
=============================================
- Coverage      96.71%   96.70%   -0.01%     
  Complexity      1906     1906              
=============================================
  Files            445      445              
  Lines          12878    12881       +3     
  Branches        2072     2072              
=============================================
+ Hits           12455    12457       +2     
- Misses           423      424       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cypress
Copy link

cypress bot commented Mar 23, 2026

PILOS    Run #2885

Run Properties:  status check passed Passed #2885  •  git commit 7620a74e7c: Add close button to room share popover (screen readers only)
Project PILOS
Branch Review a11y-add-sr-only-close-button
Run status status check passed Passed #2885
Run duration 07m 21s
Commit git commit 7620a74e7c: Add close button to room share popover (screen readers only)
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 621
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant