Fixed UrSpectatorTeleportC2SPacket #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the packet C2S with id 0x37 which was about teleport to entity on minecraft 1.20.5 is causing conflicts in newer versions like 1.21.7 so i decided to remap all ids for that packet from 1.20.5 to 1.21.7
on 1.20.5 packet 0.37 was https://github.com/derklaro/mc-protocol/blob/5dd2acf99831c1eb15753e8ccee358d74d5bfa62/readme.md#0x37---teleport-to-entity-c--s teleport to entity c2s
on 1.21.2 that packet is 0x39 https://github.com/derklaro/mc-protocol/blob/25305d646156370e0bc867f43eac02f6f58f0d04/readme.md#0x39---teleport-to-entity-c--s
on 1.21.4 that packet is 0x3B https://github.com/derklaro/mc-protocol/blob/77fe53b2888792b5600a90e905db979626db7eee/readme.md#0x3b---teleport-to-entity-c--s
on 1.21.5 that packet is 0x3C https://github.com/derklaro/mc-protocol/blob/b29d408ba88d67aa3ecb2d58898609de76d2a355/readme.md#0x3c---teleport-to-entity-c--s
on 1.21.6 that packet is 0x3D https://github.com/derklaro/mc-protocol/blob/c0cdfe4a2c52fcca88248a71c53a396dd53f2097/readme.md#0x3d---teleport-to-entity-c--s
it was causing conflicts for me on 1.21.7 on open creative menu with items on it
apparently packet id 0x37 on 1.21.7 is this one: https://github.com/derklaro/mc-protocol/blob/ccc0bcc2777404a6dfc4f9d8edcedf6358529370/readme.md#0x37---set-creative-mode-slot-c--s related to Set Creative Mode Slot which explains it all, when opening creative menu with items on any slot, the client was sending 0x37 which velocity uuid rewrite logic was interpreting as the old teleport to entity C2S
Tested on fabric server 1.21.7 0.16.14 with fabric proxy lite & fabric api