Remove arbitrary upper limit on num_vu for schema build#861
Open
hqakhtar wants to merge 1 commit intoTPC-Council:masterfrom
Open
Remove arbitrary upper limit on num_vu for schema build#861hqakhtar wants to merge 1 commit intoTPC-Council:masterfrom
hqakhtar wants to merge 1 commit intoTPC-Council:masterfrom
Conversation
Remove the hardcoded upper limit on the number of virtual users for schema building across all database backends. The warehouse/scale-factor count constraint already provides a natural upper bound, making the arbitrary numeric cap redundant. Changes: - verify_build_threads: remove maximum parameter, validate positive integer only - gencli.tcl: remove 1024 cap from TPC-C and TPC-H CLI validation - All database spinboxes: set upper bound to 100000 (matching max warehouse count) - Update all verify_build_threads callers to drop the third argument
Contributor
|
Hi, many thanks for the pull request. Yes this looks very reasonable. The limit was an artifact from a time that systems/core counts were not as performant as today so as a concept this is fine to remove this. |
sm-shaw
approved these changes
Apr 11, 2026
Contributor
sm-shaw
left a comment
sm-shaw
left a comment
There was a problem hiding this comment.
Reviewed and approved to remove build thread limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the hardcoded upper limit on the number of virtual users for schema building across all database backends. The warehouse/scale-factor count constraint already provides a natural upper bound, making the arbitrary numeric cap redundant. This will help speedup the data population by utilizing a bigger set of workers.
Changes: