Strict-parse the truepic-signature header#37
Merged
jstayton merged 1 commit intodevelopmentfrom May 7, 2026
Merged
Conversation
- Reject headers with anything other than two non-empty comma-separated parts; the previous parser silently dropped anything past the second comma. - Split each `k=v` pair on the *first* `=` only. Base64 signatures end with `=` padding, so splitting on every `=` was silently truncating the trailing padding from the signature value. Worked in practice because Node's base64 decoder is lenient about padding, but the parser was dropping bytes from its input. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t=1,s=abc,extrawas accepted).k=vpair on the first=only. Base64 signatures can end with=padding, andString.prototype.split('=')followed by 2-element destructuring was silently truncating that padding. It worked in practice because Node's base64 decoder is lenient, but the parser was dropping bytes from its input.Test plan
npm test— 16/16 pass.npm run lint— clean.🤖 Generated with Claude Code