Skip to content

Solid v2 beta 10#7284

Merged
birkskyum merged 8 commits into
solid-router-v2-prefrom
solid-v2-beta-9
Apr 30, 2026
Merged

Solid v2 beta 10#7284
birkskyum merged 8 commits into
solid-router-v2-prefrom
solid-v2-beta-9

Conversation

@brenelz
Copy link
Copy Markdown
Contributor

@brenelz brenelz commented Apr 28, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8903b70d-2072-4619-a283-1bfd94075c4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch solid-v2-beta-9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 28, 2026

View your CI Pipeline Execution ↗ for commit ad6acb6

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 1m 34s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-30 02:05:57 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

🚀 Changeset Version Preview

6 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/solid-router 2.0.0-beta.16 → 2.0.0-beta.17 Changeset
@tanstack/solid-router-devtools 2.0.0-beta.12 → 2.0.0-beta.13 Changeset
@tanstack/solid-router-ssr-query 2.0.0-beta.17 → 2.0.0-beta.18 Changeset
@tanstack/solid-start 2.0.0-beta.17 → 2.0.0-beta.18 Changeset
@tanstack/solid-start-client 2.0.0-beta.16 → 2.0.0-beta.17 Changeset
@tanstack/solid-start-server 2.0.0-beta.16 → 2.0.0-beta.17 Changeset

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Bundle Size Benchmarks

  • Commit: 7fa0f39cabf4
  • Measured at: 2026-04-30T02:05:16.740Z
  • Baseline source: history:7fa0f39cabf4
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.48 KiB +184 B (+0.21%) 275.76 KiB 75.97 KiB ▃▃▃▃▃▃▁▁▁▁▁█
react-router.full 90.78 KiB -23 B (-0.02%) 286.95 KiB 78.95 KiB ▁▁▁▁▁▁█████▁
solid-router.minimal 40.72 KiB +5.17 KiB (+14.56%) 119.90 KiB 36.76 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.full 45.12 KiB +4.84 KiB (+12.01%) 133.64 KiB 40.74 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.minimal 53.38 KiB +88 B (+0.16%) 153.07 KiB 47.94 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.full 58.25 KiB -202 B (-0.34%) 168.53 KiB 52.18 KiB ███████████▁
react-start.minimal 102.01 KiB +89 B (+0.09%) 324.00 KiB 88.21 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.full 105.38 KiB +39 B (+0.04%) 334.35 KiB 91.14 KiB ▃▃▃▃▃▃▁▁▁▁▁█
solid-start.minimal 61.33 KiB +11.78 KiB (+23.77%) 186.64 KiB 54.33 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.full 65.20 KiB +9.87 KiB (+17.84%) 198.16 KiB 57.67 KiB ▁▁▁▁▁▁▁▁▁▁▁█

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 28, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7284

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7284

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7284

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7284

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7284

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7284

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7284

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7284

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7284

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7284

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7284

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7284

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7284

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7284

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7284

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7284

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7284

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7284

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7284

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7284

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7284

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7284

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7284

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7284

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7284

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7284

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7284

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7284

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7284

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7284

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7284

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7284

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7284

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7284

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7284

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7284

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7284

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7284

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7284

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7284

commit: 299cce3

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 28, 2026

Merging this PR will degrade performance by 9.33%

❌ 1 regressed benchmark
✅ 5 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
ssr request loop (solid) 174.6 ms 192.6 ms -9.33%

Comparing solid-v2-beta-9 (299cce3) with solid-router-v2-pre (67a9040)1

Open in CodSpeed

Footnotes

  1. No successful run was found on solid-router-v2-pre (57cf15f) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Comment thread packages/solid-start-client/src/StartClient.tsx Outdated
Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud is proposing a fix for your failed CI:

We re-apply the createRenderEffect/flatten shim in StartClient.tsx that was introduced in commit 5b4049675b and then inadvertently reverted, restoring compatibility with Solid.js v2 beta.9's updated reactive scheduler. Without this call, the RouterProvider JSX is not properly connected to Solid.js v2's reactive graph during client hydration, causing all client-rendered routes to produce blank pages and failing 22/29 server-function E2E tests and 1/6 basic-solid-query E2E tests.

Tip

We verified this fix by re-running tanstack-solid-start-e2e-csp:test:e2e, tanstack-solid-start-e2e-css-modules:test:e2e, tanstack-solid-start-e2e-server-routes:test:e2e and 5 more.

diff --git a/packages/solid-start-client/src/StartClient.tsx b/packages/solid-start-client/src/StartClient.tsx
index 88fd53e732..4bfd8ecc51 100644
--- a/packages/solid-start-client/src/StartClient.tsx
+++ b/packages/solid-start-client/src/StartClient.tsx
@@ -1,6 +1,12 @@
+import * as Solid from 'solid-js'
 import { RouterProvider } from '@tanstack/solid-router'
 import type { AnyRouter } from '@tanstack/router-core'
 
 export function StartClient(props: { router: AnyRouter }) {
-  return <RouterProvider router={props.router} />
+  const routerProvider = <RouterProvider router={props.router} />
+  Solid.createRenderEffect(
+    () => Solid.flatten(routerProvider),
+    () => {},
+  )
+  return routerProvider
 }

Apply fix via Nx Cloud  Reject fix via Nx Cloud


Or Apply changes locally with:

npx nx-cloud apply-locally GjBI-xyFa

Apply fix locally with your editor ↗   View interactive diff ↗



🎓 Learn more about Self-Healing CI on nx.dev

@brenelz brenelz changed the title Solid v2 beta 9 Solid v2 beta 10 Apr 30, 2026
@birkskyum birkskyum merged commit 401272e into solid-router-v2-pre Apr 30, 2026
17 of 18 checks passed
@birkskyum birkskyum deleted the solid-v2-beta-9 branch April 30, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants