Skip to content

Conversation

@yuechao-qin
Copy link
Collaborator

@yuechao-qin yuechao-qin commented Jan 16, 2026

Description

Changed the overflow behavior in the ComponentDetailsDialog from overflow-hidden to overflow-auto to enable scrolling within the component details section.

Type of Change

  • Bug fix

Tests

Reproduce error on production

  • Go to production https://oasis.shopify.io/
  • Open up a pipeline with components in the pipeline
  • Click the info next to the pipeline and in the Details tab note you cannot scroll. You can expand the description section to get some more heigh real estate.

Video of local fix vs. production

Screen Recording 2026-01-16 at 2.41.55 PM.mov (uploaded via Graphite)

@yuechao-qin yuechao-qin marked this pull request as ready for review January 16, 2026 19:44
@yuechao-qin yuechao-qin requested a review from a team as a code owner January 16, 2026 19:44
@yuechao-qin yuechao-qin force-pushed the ycq/manage-component-usage-count branch from 58726d0 to d873fc9 Compare January 22, 2026 19:54
@yuechao-qin yuechao-qin force-pushed the ycq/fix-comp-details-scroll branch from 9694763 to 885b101 Compare January 22, 2026 19:54
@yuechao-qin yuechao-qin force-pushed the ycq/fix-comp-details-scroll branch from 885b101 to 9e258f5 Compare January 22, 2026 20:15
@yuechao-qin yuechao-qin force-pushed the ycq/manage-component-usage-count branch 2 times, most recently from 2b31182 to 0cd529d Compare January 22, 2026 20:17
@yuechao-qin yuechao-qin force-pushed the ycq/fix-comp-details-scroll branch from 9e258f5 to a3f4780 Compare January 22, 2026 20:18
@graphite-app graphite-app bot changed the base branch from ycq/manage-component-usage-count to graphite-base/1655 January 22, 2026 20:21
@yuechao-qin yuechao-qin force-pushed the ycq/fix-comp-details-scroll branch from a3f4780 to 5519f5e Compare January 22, 2026 22:25
@yuechao-qin yuechao-qin changed the base branch from graphite-base/1655 to ycq/manage-component-usage-count January 22, 2026 22:25
@yuechao-qin yuechao-qin changed the base branch from ycq/manage-component-usage-count to graphite-base/1655 January 22, 2026 22:27
@yuechao-qin yuechao-qin force-pushed the ycq/fix-comp-details-scroll branch from 5519f5e to 84fffca Compare January 22, 2026 22:28
@graphite-app graphite-app bot changed the base branch from graphite-base/1655 to master January 22, 2026 22:28
@yuechao-qin yuechao-qin force-pushed the ycq/fix-comp-details-scroll branch from 84fffca to ca5b111 Compare January 22, 2026 22:28
@yuechao-qin yuechao-qin merged commit dd60226 into master Jan 22, 2026
8 checks passed
Copy link
Collaborator Author

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants