Skip to content

Conversation

@Mbeaulne
Copy link
Collaborator

@Mbeaulne Mbeaulne commented Jan 27, 2026

Description

Resolves: https://github.com/Shopify/oasis-frontend/issues/458

Added a new AnnotationFilterInput component that allows users to filter by annotations. The component includes:

  • A clean UI for adding and removing annotation filters
  • Support for key-only filters or key-value pairs
  • Keyboard navigation (Enter to add, Escape to cancel)
  • Accessible remove buttons for each filter badge
  • Comprehensive test coverage

Type of Change

  • New feature
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

N/A

Test Instructions

  1. Navigate to any page where the AnnotationFilterInput component is used
  2. Click "Add filter" and enter a key (and optionally a value)
  3. Press Enter or click "Add" to create the filter
  4. Verify the filter appears as a badge
  5. Click the X on a badge to remove the filter
  6. Test keyboard navigation (Enter to add, Escape to cancel)

Copy link
Collaborator Author

Mbeaulne commented Jan 27, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Mbeaulne Mbeaulne mentioned this pull request Jan 27, 2026
4 tasks
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from 702e058 to 055a218 Compare January 27, 2026 15:48
This was referenced Jan 27, 2026
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from 055a218 to aeda0ef Compare January 27, 2026 15:59
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch 3 times, most recently from 185fc8e to d548dd0 Compare January 27, 2026 16:39
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from d548dd0 to 57641b0 Compare January 27, 2026 18:57
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from 57641b0 to 60e5301 Compare January 28, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants