fix(migrator): portable schema_migrations DDL for non-Postgres backends#116
Merged
Conversation
ensure_schema_migrations/1 emitted TIMESTAMPTZ + DEFAULT now() which SQLite's parser rejects. Switch to TIMESTAMP + CURRENT_TIMESTAMP - both Postgres and SQLite accept it, and the column is internal bookkeeping so the lack of timezone info doesn't matter. Caught by a new SQLite migrator e2e test in kura_sqlite.
🟢 Code Coverage — 91.6%2170 of 2368 lines covered. ✅ ELP LintNo diagnostics. ℹ️ 11 OTP CVEs auto-ignored (already fixed in running version)These CVEs are patched in the installed OTP version but NVD data
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kura_migrator:ensure_schema_migrations/1emitted Postgres-only DDL (TIMESTAMPTZ,DEFAULT now()) which SQLite's parser rejects. Switches to portable SQL (TIMESTAMP,CURRENT_TIMESTAMP) that both Postgres and SQLite accept.Why
Caught by a new SQLite migrator end-to-end test in kura_sqlite. The schema_migrations table is internal bookkeeping; the lack of timezone info doesn't affect application-level data.
Test plan