fix(migrator): code:ensure_loaded dialect before function_exported check#117
Merged
Conversation
erlang:function_exported/3 returns false for any module not yet loaded in the runtime. Without this, kura_migrator never sees a dialect's column_type/1 / format_default/1 callbacks unless the dialect happens to have been called before, and silently falls back to the Postgres-shaped defaults. This was the root cause of CREATE TABLE emitting BIGSERIAL on a SQLite repo — the dialect was configured correctly but the override machinery never ran. Caught by kura_sqlite's new end-to-end migrator test.
🟢 Code Coverage — 91.6%2172 of 2370 lines covered. ✅ ELP LintNo diagnostics. ℹ️ 11 OTP CVEs auto-ignored (already fixed in running version)These CVEs are patched in the installed OTP version but NVD data
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
erlang:function_exported/3only sees modules currently loaded in the runtime. Withoutcode:ensure_loaded/1, kura_migrator never picked up a dialect'scolumn_type/1/format_default/1callbacks unless that dialect happened to have been called before, and silently fell back to the Postgres-shaped defaults.Symptom
CREATE TABLE on a SQLite repo emitted
BIGSERIAL(Postgres-only) and crashed withSQLITE_ERROR. Caught by kura_sqlite's new end-to-end migrator test.Test plan