Skip to content

feat(dialect): column_type/format_default + SQLite type mapping #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Taure merged 1 commit into from
May 10, 2026
Merged

feat(dialect): column_type/format_default + SQLite type mapping #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{erl_opts, [debug_info, warnings_as_errors]}.

{deps, [
{kura, {git, "https://github.com/Taure/kura.git", {tag, "v2.0.0"}}},
{kura, {git, "https://github.com/Taure/kura.git", {tag, "v2.1.0"}}},
{esqlite, "~> 0.9"}
]}.

Expand Down
78 changes: 74 additions & 4 deletions src/kura_dialect_sqlite.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ phase 2 skeleton and will be addressed by capability flags in phase 3.

-behaviour(kura_dialect).

-include_lib("kura/include/kura.hrl").

-eqwalizer({nowarn_function, format_default/1}).

-export([
to_sql/1,
to_sql_from/2,
Expand All @@ -40,19 +44,21 @@ phase 2 skeleton and will be addressed by capability flags in phase 3.
delete_all/1,
insert_all/3,
insert_all/4,
column_type/1,
format_default/1,
swap_placeholders/1
]).

%%----------------------------------------------------------------------
%% kura_dialect callbacks
%%----------------------------------------------------------------------

-spec to_sql(term()) -> {iodata(), [term()]}.
-spec to_sql(#kura_query{}) -> {iodata(), [term()]}.
to_sql(Query) ->
{SQL, Params} = kura_dialect_pg:to_sql(Query),
{swap_placeholders(SQL), Params}.

-spec to_sql_from(term(), pos_integer()) -> {iodata(), [term()], pos_integer()}.
-spec to_sql_from(#kura_query{}, pos_integer()) -> {iodata(), [term()], pos_integer()}.
to_sql_from(Query, StartCounter) ->
{SQL, Params, NextCounter} = kura_dialect_pg:to_sql_from(Query, StartCounter),
{swap_placeholders(SQL), Params, NextCounter}.
Expand All @@ -77,12 +83,12 @@ delete(SchemaOrTable, PKField, PKValue) ->
{SQL, Params} = kura_dialect_pg:delete(SchemaOrTable, PKField, PKValue),
{swap_placeholders(SQL), Params}.

-spec update_all(term(), map()) -> {iodata(), [term()]}.
-spec update_all(#kura_query{}, map()) -> {iodata(), [term()]}.
update_all(Query, SetMap) ->
{SQL, Params} = kura_dialect_pg:update_all(Query, SetMap),
{swap_placeholders(SQL), Params}.

-spec delete_all(term()) -> {iodata(), [term()]}.
-spec delete_all(#kura_query{}) -> {iodata(), [term()]}.
delete_all(Query) ->
{SQL, Params} = kura_dialect_pg:delete_all(Query),
{swap_placeholders(SQL), Params}.
Expand All @@ -97,6 +103,70 @@ insert_all(SchemaOrTable, Fields, Rows, Opts) ->
{SQL, Params} = kura_dialect_pg:insert_all(SchemaOrTable, Fields, Rows, Opts),
{swap_placeholders(SQL), Params}.

%%----------------------------------------------------------------------
%% DDL: column type + default value emit
%%----------------------------------------------------------------------

-spec column_type(kura_types:kura_type()) -> binary().
column_type(id) ->
~"INTEGER";
column_type(integer) ->
~"INTEGER";
column_type(bigint) ->
~"INTEGER";
column_type(smallint) ->
~"INTEGER";
column_type(float) ->
~"REAL";
column_type(decimal) ->
~"NUMERIC";
column_type(string) ->
~"TEXT";
column_type(text) ->
~"TEXT";
column_type(binary) ->
~"BLOB";
column_type(boolean) ->
~"INTEGER";
column_type(date) ->
~"TEXT";
column_type(time) ->
~"TEXT";
column_type(utc_datetime) ->
~"TEXT";
column_type(naive_datetime) ->
~"TEXT";
column_type(uuid) ->
~"TEXT";
column_type(jsonb) ->
~"TEXT";
column_type({enum, _}) ->
~"TEXT";
column_type({array, _}) ->
~"TEXT";
column_type({embed, _, _}) ->
~"TEXT";
column_type({custom, Mod}) ->
case erlang:function_exported(Mod, sqlite_type, 0) of
true -> Mod:sqlite_type();
false -> Mod:pg_type()
end.

-spec format_default(term()) -> binary().
format_default(Val) when is_integer(Val) -> integer_to_binary(Val);
format_default(Val) when is_float(Val) -> float_to_binary(Val);
format_default(Val) when is_binary(Val) -> <<"'", Val/binary, "'">>;
format_default(true) ->
~"1";
format_default(false) ->
~"0";
format_default(Val) when is_map(Val) ->
Json = iolist_to_binary(json:encode(Val)),
<<"'", Json/binary, "'">>;
format_default(Val) when is_list(Val) ->
Json = iolist_to_binary(json:encode(Val)),
<<"'", Json/binary, "'">>.

%%----------------------------------------------------------------------
%% Helpers
%%----------------------------------------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions src/kura_driver_sqlite.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ calls inside the fun route to the same conn.

-behaviour(kura_driver).

-eqwalizer({nowarn_function, query/5}).
-eqwalizer({nowarn_function, transaction/4}).
-eqwalizer({nowarn_function, collect_rows/3}).

-export([
query/5,
query_on/4,
Expand Down
33 changes: 33 additions & 0 deletions test/kura_dialect_sqlite_tests.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,39 @@ swap_double_digit_placeholder_test() ->
<<"SELECT ?12, ?34">>, kura_dialect_sqlite:swap_placeholders(<<"SELECT $12, $34">>)
).

%%----------------------------------------------------------------------
%% column_type/1: SQLite type mapping
%%----------------------------------------------------------------------

column_type_basics_test_() ->
[
?_assertEqual(~"INTEGER", kura_dialect_sqlite:column_type(id)),
?_assertEqual(~"INTEGER", kura_dialect_sqlite:column_type(integer)),
?_assertEqual(~"INTEGER", kura_dialect_sqlite:column_type(boolean)),
?_assertEqual(~"REAL", kura_dialect_sqlite:column_type(float)),
?_assertEqual(~"TEXT", kura_dialect_sqlite:column_type(string)),
?_assertEqual(~"TEXT", kura_dialect_sqlite:column_type(text)),
?_assertEqual(~"TEXT", kura_dialect_sqlite:column_type(uuid)),
?_assertEqual(~"TEXT", kura_dialect_sqlite:column_type(jsonb)),
?_assertEqual(~"TEXT", kura_dialect_sqlite:column_type(utc_datetime)),
?_assertEqual(~"BLOB", kura_dialect_sqlite:column_type(binary)),
?_assertEqual(~"TEXT", kura_dialect_sqlite:column_type({enum, [a, b]})),
?_assertEqual(~"TEXT", kura_dialect_sqlite:column_type({array, integer}))
].

%%----------------------------------------------------------------------
%% format_default/1: SQLite-flavoured default literals
%%----------------------------------------------------------------------

format_default_test_() ->
[
?_assertEqual(~"42", kura_dialect_sqlite:format_default(42)),
?_assertEqual(~"1", kura_dialect_sqlite:format_default(true)),
?_assertEqual(~"0", kura_dialect_sqlite:format_default(false)),
?_assertEqual(<<"'hello'">>, kura_dialect_sqlite:format_default(<<"hello">>)),
?_assertEqual(<<"'{\"a\":1}'">>, kura_dialect_sqlite:format_default(#{a => 1}))
].

%%----------------------------------------------------------------------
%% Behaviour declaration
%%----------------------------------------------------------------------
Expand Down
Loading