chore: repin kura to v2.0.0 + update tests for compile_operation/2#6
Merged
Conversation
The v2.4.0 tag was deleted as part of the kura 2.x consolidation
(nothing was on Hex). v2.0.0 is the new stable line.
Also fixes the smoke tests: kura_migrator:compile_operation took on
a RepoMod first arg in v2.0 to support per-repo dialect resolution.
Tests now thread a fake repo + configure the dialect via {repos, ...}.
String/binary handling in kura_pool_sqlite:to_filename/1 was already
correct - no normalization fix needed (unlike kura_postgres v0.4.2).
🟠 Code Coverage — 58.9%103 of 175 lines covered. 🟡 ELP Lint — 1 warning2 diagnostics found. See job logs for details. ℹ️ 11 OTP CVEs auto-ignored (already fixed in running version)These CVEs are patched in the installed OTP version but NVD data
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kura_migrator:compile_operationnow takesRepoModas the first argNotes
Audited string/binary handling here too -
kura_pool_sqlite:to_filename/1already accepts both forms, so no normalization fix is needed (unlike kura_postgres v0.4.2 which hadbinary_to_listcalls that crashed on string configs).Test plan
rebar3 fmt --checkrebar3 xrefrebar3 dialyzer~/bin/elp eqwalize-allrebar3 eunit39/39