Skip to content

fix: auto-migrate shigoto tables on application start#28

Merged
Taure merged 1 commit into
mainfrom
fix/auto-migrate-on-start
Apr 3, 2026
Merged

fix: auto-migrate shigoto tables on application start#28
Taure merged 1 commit into
mainfrom
fix/auto-migrate-on-start

Conversation

@Taure
Copy link
Copy Markdown
Owner

@Taure Taure commented Apr 3, 2026

Summary

  • Call shigoto_migration:up/1 automatically in shigoto_app:start/2
  • Tables are created when the application starts, no manual migration step needed
  • Migrations are idempotent — safe to run on every startup

Problem

Users had to manually call shigoto_migration:up(Pool) in their app's startup. Forgetting this caused cryptic relation "shigoto_jobs" does not exist errors at runtime with no hint about what was missing.

Test plan

  • All 84 existing tests pass (tests don't start shigoto via OTP app, so unaffected)
  • Dialyzer clean
  • xref clean

Call shigoto_migration:up/1 in shigoto_app:start/2 so tables
are created automatically. Previously users had to call
shigoto_migration:up/1 manually, which was easy to forget
and caused cryptic "relation shigoto_jobs does not exist" errors.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

🔴 Code Coverage — 49.9%

640 of 1283 lines covered.


✅ ELP Lint

No diagnostics.


ℹ️ 11 OTP CVEs auto-ignored (already fixed in running version)

These CVEs are patched in the installed OTP version but NVD data
has not been updated to reflect this. They are excluded from the
scan via an auto-generated .trivyignore.

CVE Details
CVE-2026-23943 Fixed in 28.4.1, running 28.4.1 — Pre-auth SSH DoS via unbounded zlib inflate
CVE-2026-23942 Fixed in 28.4.1, running 28.4.1 — SFTP root escape via component-agnostic prefix check in ssh_sftpd
CVE-2026-23941 Fixed in 28.4.1, running 28.4.1 — Request smuggling via first-wins Content-Length parsing in inets httpd
CVE-2026-21620 Fixed in 28.3.2, running 28.4.1 — TFTP Path Traversal
CVE-2016-1000107 Fixed in 28.0.4, running 28.4.1 — Httpd CGI Scripts Environment Variable Pollution AKA "httpoxy"
CVE-2025-58050 Fixed in 28.0.3, running 28.4.1 — Buffer Read Overflow on Regular Expressions with (*scs:) and (*ACCEPT)
CVE-2025-48038 Fixed in 28.0.3, running 28.4.1 — SSH Unverified File Handles can Cause Excessive Use of System Resources
CVE-2025-48039 Fixed in 28.0.3, running 28.4.1 — SSH Unverified Paths can Cause Excessive Use of System Resources
CVE-2025-48040 Fixed in 28.0.3, running 28.4.1 — SSH Malicious Key Exchange Messages may Lead to Excessive Resource Consumption
CVE-2025-48041 Fixed in 28.0.3, running 28.4.1 — SSH_FXP_OPENDIR may Lead to Exhaustion of File Handles
CVE-2025-4748 Fixed in 28.0.1, running 28.4.1 — Absolute Path in Zip Module

@Taure Taure merged commit 075019d into main Apr 3, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant