Skip to content

fix: fix invalid gamemode id again for hero stats#396

Merged
TeKrop merged 1 commit intomainfrom
bugfix/hero-stats-invalid-gamemode-id
Mar 17, 2026
Merged

fix: fix invalid gamemode id again for hero stats#396
TeKrop merged 1 commit intomainfrom
bugfix/hero-stats-invalid-gamemode-id

Conversation

@TeKrop
Copy link
Owner

@TeKrop TeKrop commented Mar 17, 2026

Blizzard changed the id again for Competitive data. As they're not returning any error when the input is invalid, it hasn't been detected. I changed the id again so it works fine.

Summary by Sourcery

Bug Fixes:

  • Correct the Competitive gamemode ID mapping in hero stats summary parsing so Competitive data is retrieved properly.

@TeKrop TeKrop self-assigned this Mar 17, 2026
@TeKrop TeKrop added bug Something isn't working blizzard-issue Issue coming from Blizzard (wrong data, performance issue, etc.) labels Mar 17, 2026
@TeKrop TeKrop linked an issue Mar 17, 2026 that may be closed by this pull request
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 17, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the competitive gamemode ID mapping for hero stats parsing to use the newly correct Blizzard value so competitive hero stats resolve correctly again.

File-Level Changes

Change Details Files
Update competitive gamemode identifier used when parsing hero stats so it matches Blizzard’s latest ID.
  • Change the PlayerGamemode.COMPETITIVE mapping value in GAMEMODE_MAPPING from "2" to "1" so competitive mode hero stats are requested/parsing with the correct gamemode ID.
app/domain/parsers/hero_stats_summary.py

Assessment against linked issues

Issue Objective Addressed Explanation
#395 Ensure that the /heroes/stats endpoint correctly respects the gamemode query parameter so that competitive and quickplay return distinct stats by using the correct internal gamemode IDs.

Possibly linked issues

  • #Map filter with competitive gamemode returns 400 for all maps: Issue’s competitive+map 400s stem from wrong competitive gamemode ID; PR fixes that ID mapping.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sonarqubecloud
Copy link

@TeKrop TeKrop merged commit a267e9c into main Mar 17, 2026
5 checks passed
@TeKrop TeKrop deleted the bugfix/hero-stats-invalid-gamemode-id branch March 17, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blizzard-issue Issue coming from Blizzard (wrong data, performance issue, etc.) bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hero/stats only returns quickplay stats

1 participant