fix: move setState calls inside async load function in useDashboard#102
Open
vaanni47 wants to merge 2 commits into
Open
fix: move setState calls inside async load function in useDashboard#102vaanni47 wants to merge 2 commits into
vaanni47 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors useDashboard’s data-fetching effect to use an inner async load() function, keeping the dispatch flow (start/success/error) contained within a single async control path for readability and consistency.
Changes:
- Replaced
Promise.all(...).then(...).catch(...)chaining with an innerasyncfunction usingawait+try/catch. - Moved the
FETCH_STARTdispatch into the async flow alongside the success/error dispatches.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@vaanni47 can you write tests and run this npx prettier --write src/features/user/hooks/useDashboard.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the setState (dispatch) calls inside an async load function within the useEffect in useDashboard.ts.
Previously, the effect used Promise chaining (.then/.catch) with dispatch calls outside an async context. This refactors it to use an inner async function
load()so all state updates happen inside the async flow, which is cleaner and avoids potential race conditions.Closes #76