Skip to content

fix: move setState calls inside async load function in useDashboard#102

Open
vaanni47 wants to merge 2 commits into
Team-NoxVeil:mainfrom
vaanni47:fix/use-dashboard-setstate
Open

fix: move setState calls inside async load function in useDashboard#102
vaanni47 wants to merge 2 commits into
Team-NoxVeil:mainfrom
vaanni47:fix/use-dashboard-setstate

Conversation

@vaanni47
Copy link
Copy Markdown

Moves the setState (dispatch) calls inside an async load function within the useEffect in useDashboard.ts.

Previously, the effect used Promise chaining (.then/.catch) with dispatch calls outside an async context. This refactors it to use an inner async function load() so all state updates happen inside the async flow, which is cleaner and avoids potential race conditions.

Closes #76

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors useDashboard’s data-fetching effect to use an inner async load() function, keeping the dispatch flow (start/success/error) contained within a single async control path for readability and consistency.

Changes:

  • Replaced Promise.all(...).then(...).catch(...) chaining with an inner async function using await + try/catch.
  • Moved the FETCH_START dispatch into the async flow alongside the success/error dispatches.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RITVIKKAMASETTY
Copy link
Copy Markdown
Collaborator

@vaanni47 can you write tests and run this npx prettier --write src/features/user/hooks/useDashboard.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants