This repository was archived by the owner on Jan 13, 2025. It is now read-only.
add a simple method to check devices (mainly motors) for each mechanism#108
Open
dejabot wants to merge 7 commits into
Open
add a simple method to check devices (mainly motors) for each mechanism#108dejabot wants to merge 7 commits into
dejabot wants to merge 7 commits into
Conversation
…CheckDevices procedure that checks each mechanism and signals whether or not the checks passed.
00a5bc9 to
02164ec
Compare
rcahoon
approved these changes
Mar 31, 2024
Member
rcahoon
left a comment
There was a problem hiding this comment.
lgtm for 2024. we should reevaluate for a better-integrated code architecture in the off-season
Contributor
Author
|
thanks! agreed. this is a contained change for comp season (iff the students want to use something like this). for off-season, I agree that we should find ways to make this procedure catalog devices to query more easily or even automatically. I'd also like to see how we can improve the logic for whether or not a device is healthy, for more devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thought experiment to add a simple method to check devices (mainly motors for now) for each mechanism and add a CheckDevices procedure that we could call from eg DebugOI to run those checks and signal success/failure via the lights.
Could be useful for a very quick, simple pit test. Meant to complement more thorough automatic and/or manual tests.
Sending to see if students may be interested in doing something like this as part of systematizing our pit tests.
How Has This Been Tested?
Needs to be tested by:
adding a DebugOI integration.
deploying on RevA.
checking that if all devices are healthy, we see green.
checking that if a CAN bus wire or if power is disconnected for a device, we see red.
Unit tests: [Add your description here]
Simulator testing: [Add your description here]
On-robot bench testing: [Add your description here]
On-robot field testing: [Add your description here]