This repository was archived by the owner on Jan 13, 2025. It is now read-only.
Record Git SHA in Logger#139
Open
rcahoon wants to merge 1 commit into
Open
Conversation
dejabot
approved these changes
Sep 21, 2024
Contributor
dejabot
left a comment
dejabot
left a comment
There was a problem hiding this comment.
LG. Minor thoughts/suggestions for some other fields to log.
| // TODO: add support for simulation logging/replay | ||
| } | ||
|
|
||
| Logger.recordMetadata("GitSHA", BuildConstants.GIT_SHA); |
Contributor
There was a problem hiding this comment.
is it worth logging BuildConstants.{BUILD_DATE, GIT_BRANCH, DIRTY} as well?
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows us to introspect which version of the software is currently deployed to a robot
How Has This Been Tested?