This repository was archived by the owner on Jan 13, 2025. It is now read-only.
create PID helper class for running PID loops in a Mechanism's run method#50
Open
dejabot wants to merge 8 commits into
Open
create PID helper class for running PID loops in a Mechanism's run method#50dejabot wants to merge 8 commits into
dejabot wants to merge 8 commits into
Conversation
rcahoon
reviewed
Feb 29, 2024
| // changed, set the setpoint. | ||
| if (first | ||
| || prevSetPoint != currentSetPoint | ||
| || prevArbitraryFeedForward != currentArbitraryFeedForward |
Member
There was a problem hiding this comment.
FYI, for arbitraryFeedForward strategies based on sensors (e.g. cosineArbitraryFeedForward), the value will likely change on every evaluation
Contributor
Author
There was a problem hiding this comment.
thx! q - wouldn't it stop once the mechanism stopped moving? or would there be unintended micromovements, eg from vibrations, etc.
in that case, wdyt of using a minimum change threshold?
Member
There was a problem hiding this comment.
yes. in addition, many sensors will have signal noise that results in different measurements, even if the mechanism is perfectly still.
a change threshold is probably fine. i would think at most 0.01, unless you want to make it configurable
…method. update RevA's Shoulder to use this, as an example.
rcahoon
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thought exercise to simplify running PID loops in a Mechanism's
runmethod.PIDRunnerhandles:setmethod iff this is the first call, if the setpoint, slot, or feedforward have changed.How Has This Been Tested?
Needs to be tested. Sending for early feedback.