Skip to content
This repository was archived by the owner on Jan 24, 2026. It is now read-only.

Hierarchical rules#9

Merged
rcahoon merged 1 commit into
mf3-devfrom
rcahoon/mf3-rule-hierarchy
Jan 14, 2025
Merged

Hierarchical rules#9
rcahoon merged 1 commit into
mf3-devfrom
rcahoon/mf3-rule-hierarchy

Conversation

@rcahoon
Copy link
Copy Markdown
Member

@rcahoon rcahoon commented Jan 10, 2025

Description

Allow defining Rules in a hierarchy so that the Rules' conditions compose. This is useful for specifying controls for different "modes" of the robot.

Original PR from 2024 repo: Team766/2024#147

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Be detailed so that your code reviewer can understand exactly how much and what kinds of testing were done, and which might still be worthwhile to do.

  • Unit tests: Units tests for new functionality are included in this PR
  • Simulator testing: [Add your description here]
  • On-robot bench testing: [Add your description here]
  • On-robot field testing: [Add your description here]

@rcahoon rcahoon requested a review from dejabot January 10, 2025 08:02
@rcahoon rcahoon force-pushed the rcahoon/mf3-rule-hierarchy branch 2 times, most recently from 89a0c56 to 17e704e Compare January 10, 2025 13:10
@rcahoon rcahoon force-pushed the rcahoon/mf3-rule-persistence branch from f8d72f3 to 5a4a3ae Compare January 13, 2025 03:22
@rcahoon rcahoon force-pushed the rcahoon/mf3-rule-hierarchy branch 3 times, most recently from 7b0601a to 32aa7be Compare January 13, 2025 03:41
@dejabot
Copy link
Copy Markdown
Contributor

dejabot commented Jan 13, 2025

want to discuss f2f and refresh myself on use cases.

Base automatically changed from rcahoon/mf3-rule-persistence to mf3-dev January 13, 2025 08:04
@rcahoon rcahoon force-pushed the rcahoon/mf3-rule-hierarchy branch from 4a7cf6e to a3e6acb Compare January 13, 2025 08:08
@rcahoon rcahoon force-pushed the rcahoon/mf3-rule-hierarchy branch from a3e6acb to a6e3b3e Compare January 13, 2025 08:12
Copy link
Copy Markdown
Contributor

@dejabot dejabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcahoon rcahoon merged commit d810772 into mf3-dev Jan 14, 2025
@rcahoon rcahoon deleted the rcahoon/mf3-rule-hierarchy branch January 14, 2025 06:07
rajitzg pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants