fix: preserve last modified time#763
Open
YuevUwU wants to merge 1 commit intoTeamFlos:mainfrom
Open
Conversation
- files in chart will keep it. - zip by multi-export will all be seen as the same time as top-level zip. (the time before zipping) - Enable `chrono` feature of `zip` - NOTICE: `chrono` feature also add logic with `std::fs::File::set_modified` on `zip::read::ZipArchive::extract`. I'm not sure if there are some OS allows to write but deny write metadata. Currently, Phira using their custom logic (not `extract`), and the last modified time is still import time. It may still cause unavailablility for what we don't need in the future, so may need to remember it. (even if it's difficult to handle completely)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #746
Close #761
Changes and Choice
chronofeature ofzipchronofeature forzip, instead oftimecurrently due to crate addition and complexitySystemTimemay have no existing method to convert tozip::DateTimeimpl chrono::NaiveDateTime for zip::Datetimeis only available ifchronofeature is enabledchronofeature won't set modified time as "current timestamp". That is onlytimefeature would do.NOTICE
chronofeature also add logic withstd::fs::File::set_modifiedonzip::read::ZipArchive::extract(src). I'm not sure if there are some OS allows to write but deny write metadata. Currently, Phira using their custom logic (notextract), and the last modified time is still import time. It may still cause unavailablility for what we don't need in the future, so may need to remember it. (even if it's difficult to handle completely)BTW
There is a maybe unused function about writing zip. It had used on Mivik/prpr.
I just keep it original.
phira/prpr/src/fs.rs
Line 22 in 15903cd