Allow non-sf-symbol icons (through fallback)#2
Open
adriangronau wants to merge 1 commit intoTechSupportz:mainfrom
Open
Allow non-sf-symbol icons (through fallback)#2adriangronau wants to merge 1 commit intoTechSupportz:mainfrom
adriangronau wants to merge 1 commit intoTechSupportz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support more than just SF symbol icons, I've added this simple fallback that allows any image to be used as an icon in the tab bar.
The custom images have to be manually added to the image assets in Xcode bbut it's quite easy to do so.
Please let me know if this change would make sense to add to the repository!