Open
Conversation
Member
|
Thanks for the PR. I really appreciate this since this app was planned but would have taken time otherwise due to many other stuff that are pending. Will get this reviewed soon and merge it. |
EnesEfeTokta
reviewed
Dec 8, 2025
EnesEfeTokta
left a comment
EnesEfeTokta
left a comment
There was a problem hiding this comment.
I think it looks okay. Good job.
Author
|
Do note that I haven't done extensive testing on it. I decided to personally stick with PiHole for DNS due to the lack of certain information from the logs (Most notably host names and mac addresses of devices making requests.) |
|
I have tested this locally and it appears to be functioning as expected. |
Contributor
|
Would also love to see this merged as I'm consolidating storage across several apps onto PostgreSQL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PostgreSQL as a database backend.
This is based off of the MySQL backend with a few things changed to allow it to work with PostgreSQL.