Bump node-sass to fix build#23
Open
sqozz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my naive attempt to fix the build of this tool. On modern systems there is no python2 present which is required by the old version of node-sass. I just took the newest release I found on https://www.npmjs.com/package/node-sass and ran
yarn install --mode update-lockfileto regenerate the lock file. Afterwards I was able to install/compile the tool withnpm install ..This might also fix https://github.com/Templarian/MaterialDesign/actions/workflows/cd-font-build.yml but I don't know how the whole publishing in the background works. I was at least able to generate a new ttf-font with these changes here too.
I'm a complete noob regarding npm/node so excuse me if this is completely wrong. I just wanted to share, what worked for me.