feat: enhance WebSocket connection handling for embedded mode#628
Open
Chakyiu wants to merge 1 commit intoTermix-SSH:mainfrom
Open
feat: enhance WebSocket connection handling for embedded mode#628Chakyiu wants to merge 1 commit intoTermix-SSH:mainfrom
Chakyiu wants to merge 1 commit intoTermix-SSH:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changes Made
in Electron mode, the terminal WebSocket was connecting to 'ws://127.0.0.1:30001/ssh/websocket/' (the Express HTTP server on port 30001), but the WebSocket server is a standalone server on port 30002 — Express doesn't handle WebSocket upgrades, so the connection was immediately dropped with code 1006.
Related Issues
None
Screenshots / Demos
SSH Connection Error
5:07:25 PM Connection closed unexpectedly. This may be due to a reverse proxy or SSL configuration issue. Please check server logs.
Checklist