fix(auth): pass JWT token via URL for Electron/mobile OIDC callback#630
Open
jozefrebjak wants to merge 1 commit intoTermix-SSH:mainfrom
Open
fix(auth): pass JWT token via URL for Electron/mobile OIDC callback#630jozefrebjak wants to merge 1 commit intoTermix-SSH:mainfrom
jozefrebjak wants to merge 1 commit intoTermix-SSH:mainfrom
Conversation
…back The OIDC callback redirect did not include the JWT token as a URL parameter for desktop/mobile device types, causing Electron and React Native webviews to have jwt = undefined after login. Closes Termix-SSH/Support#562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After OIDC login on Electron desktop or mobile app, the JWT token was not being stored — resulting in
jwt = undefinedand broken terminal connections.The fix adds the JWT token as a URL parameter during the OIDC callback redirect for desktop/mobile device types. The Electron and mobile Auth components then read this token from the URL and store it in localStorage.
Web browser login is not affected — token is only passed via URL for Electron and React Native webview contexts.
This still needs to be tested on macOS Electron app and mobile app before merging.
Closes Termix-SSH/Support#562
Related: #414, #465