Skip to content

Don't select when the mouse is moving before a click. Considere event… #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LabordePierre merged 1 commit into from
Apr 22, 2026
Merged

Don't select when the mouse is moving before a click. Considere event… #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/GeoView/GeoViewInteractionsStrategy.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,12 @@ GeoViewInteractionsStrategy >> mouseDownEvent: anEvent [
GeoViewInteractionsStrategy >> mouseMoveEvent: anEvent [

"Sampling mouse events"
lastMouseMoveEventTimestamp ifNotNil:[ | duration |
duration := anEvent timestamp - lastMouseMoveEventTimestamp.
| lastMouseMoveEvent |
lastMouseMoveEvent := self getLastEvent: BlMouseMoveEvent.
lastMouseMoveEvent ifNotNil:[ | duration |
duration := anEvent timestamp - lastMouseMoveEvent timestamp.
duration < self pulseDuration ifTrue:[ ^ self ].
].
lastMouseMoveEventTimestamp := anEvent timestamp copy.

self sendMouseCoordinatesChanged: anEvent.

Expand Down Expand Up @@ -176,10 +177,16 @@ GeoViewInteractionsStrategy >> moveMap: anEvent [
{ #category : #'mouse handlers' }
GeoViewInteractionsStrategy >> primaryClickEvent: anEvent [

| from distance |
self allowSelection ifFalse:[ ^ self ].
self isMapMoving ifTrue:[ ^ self ].

self selectOnClick: anEvent
"determine if selection is available depending mouse cursor distance between mouseDown and mouseClick"
from := (self getLastEvent: BlPrimaryMouseDownEvent) ifNotNil:[ :e | e position ] ifNil:[ anEvent position ].
distance := anEvent position distanceTo: from.
distance > self pickingRadius ifTrue:[ ^ self ].

self selectOnClick: anEvent
]

{ #category : #'mouse handlers' }
Expand Down
Loading