Commit again after nuking#494
Conversation
There was a problem hiding this comment.
Hi @LordDonP . I have reviewed your calculator application, overall you have done a fantastic job with the implementation. I will give you the general disclaimer that I have only done one other review, so oddities might arise. I will add some comments with my findings!
Thank you for taking the time to learn and submit this project!
|
Validation Oddities: I noticed upon entering the app, that specifically on the num1 input validation, no matter what it will not validate it if the first number entered is invalid. I will attatch some screenshots that might clue you in to why. I will approve the project once this is fixed. 
What do you notice in your code? |
|
Your switch statement default case is empty, which is leading to an exception. Fantastic job using a Try Catch block for these exceptions as otherwise the application would crash. This does not block approval, just another oddity I noticed. 
|
|
@LordDonP It's been two weeks since the suggested changes, so we're archiving this project. Feel free to reopen the PR and resubmit in the academy when you're ready. @DSills735 You'll get your review points regardless 😁 |
3 participants
No description provided.