Skip to content

fix(release): use bare_version for prerelease flag (tray- prefix has a dash) #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntatschner wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(release): use bare_version for prerelease flag (tray- prefix has a dash) #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,19 @@ jobs:
tag_name: ${{ github.ref_name }}
name: ${{ github.ref_name }}
draft: true
# Anything with a hyphen (rc, beta, alpha, etc.) is a pre-release;
# only bare semver like tray-v0.2.0 gets marked Latest on the
# GH releases page.
prerelease: ${{ contains(github.ref_name, '-') }}
# Anything with a hyphen in the SEMVER part (rc, beta, alpha,
# etc.) is a pre-release; only bare semver like tray-v0.2.0
# gets marked Latest on the GH releases page.
#
# Critical: check `bare_version` (the part after `tray-v`),
# NOT `github.ref_name`. The `tray-` prefix itself contains
# a hyphen, so `contains(github.ref_name, '-')` returned true
# for EVERY tray release including bare-semver live ones,
# silently mis-flagging every post-split tray release as
# pre-release. Latest-badge stuck on the pre-split v1.8.3
# tag until tray-v1.8.6 (2026-05-24) — see
# release-yml-prerelease-flag fix below.
prerelease: ${{ contains(needs.validate-tag.outputs.bare_version, '-') }}
# `generate_release_notes: false` — our per-component changelog
# in release-body.md replaces GH's auto-generated notes, which
# would otherwise leak platform-only commits into the tray
Expand Down
Loading