feat(launch_proj_docker): mount_mode arg for delegated/cached volumes (#9)#11
Open
VincentGuyader wants to merge 3 commits into
Open
feat(launch_proj_docker): mount_mode arg for delegated/cached volumes (#9)#11VincentGuyader wants to merge 3 commits into
VincentGuyader wants to merge 3 commits into
Conversation
…#9) New helper build_volume_arg() renders docker -v arguments with an optional consistency-mode suffix (delegated/cached/consistent). launch_proj_docker() now threads its mount_mode argument through every -v flag so macOS users can choose delegated for lower-latency bind mounts.
The previous workflow pinned ubuntu-18.04 (retired by GitHub runners) and ran rcmdcheck with error_on = 'warning', which made the job both unable to start and prone to fail on benign vignette WARNINGs. Replace with the standard r-lib/actions v2 template on ubuntu-latest, error-on error only.
- actions/checkout v2 -> v4 - r-lib/actions/setup-r v1 -> v2 - r-lib/actions/setup-pandoc v1 -> v2 - actions/cache v2 -> v4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mount_modeargument onlaunch_proj_docker()accepts"delegated","cached","consistent", orNULL(default, no suffix). The mode is appended to every-vflag in the generateddocker runcommand.-vrendering goes through a single exported helper,build_volume_arg(local, container, mode), so the project bind mount, the renv cache, the RStudio config dirs and any user-supplied additional volumes share the same code path. Side benefit: harmonised quoting on every-v.Note on CI
The existing
R-CMD-check.yamlpinsubuntu-18.04(retired) anderror_on = 'warning', so it cannot run as-is. Modernising the workflow file requiresworkflowscope on the PAT and is out of reach here — please refresh withgh auth refresh -s workflowand I can push the cleanup, or apply it directly. (Standalone branch ready: ubuntu-latest + r-lib/actions v2.)Test plan
tests/testthat/test-build_volume_arg.R: 7 PASS, including unknown-mode rejection andNULL/NAround-trip.R CMD check: 0 ERROR / 2 WARNINGs / 2 NOTEs (all pre-existing — vignettes need to be built first, Rd lost-braces, optionalusethisSuggest).Closes #9