Skip to content

Comments

new icon: testingicon (original, plain)#101

Open
Thomas-Boi wants to merge 89 commits intodevelopfrom
testing
Open

new icon: testingicon (original, plain)#101
Thomas-Boi wants to merge 89 commits intodevelopfrom
testing

Conversation

@Thomas-Boi
Copy link
Owner

New icon section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • The PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date


New feature section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format New Feature: a brief description of feature

This PR adds/fixes

Notes

@github-actions
Copy link

Hi!

I'm the check-bot and we have some issues with your PR:


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link

Hi!

I'm the check-bot and we have some issues with your PR:

Error found in 'devicon.json' for 'testingicon' entry: 
- missing key: 'aliases'.


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link

Hi!

I'm the check-bot and we have some issues with your PR:

Error found in 'devicon.json' for 'testingicon' entry: 
- Invalid version name in 'svg': {}. Must match regexp: (original|plain|line)(-wordmark)?
- missing key: 'aliases'.

Error in /home/runner/work/devicon/devicon/icons/testingicon/testingicon-origi.svg:
- SVG file name didn't match our pattern of `name-(original|plain|line)(-wordmark)?.svg`

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant