drop broken function - no replacement for now, so old icals forever exist in storage#145
drop broken function - no replacement for now, so old icals forever exist in storage#145
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc41ad93c8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| AFTER DELETE ON public.icals | ||
| FOR EACH ROW | ||
| EXECUTE PROCEDURE public.handle_ical_deletion(); No newline at end of file | ||
| -- Storage file cleanup is handled in application code via the Supabase Storage API. |
There was a problem hiding this comment.
Removing the on_ical_deleted trigger leaves no actual cleanup path for old .ics objects even though this comment says cleanup is in application code: the only delete flow in apps/web/src/lib/components/recal/modals/schedule/ExportCal.svelte removes rows from icals (.from("icals").delete()) and then uploads a new random file, with no supabase.storage.from("calendars").remove(...) call. As a result, previously issued public calendar URLs remain accessible indefinitely and users cannot revoke old links by regenerating exports, while storage usage continuously accumulates.
Useful? React with 👍 / 👎.
|
At the very least, calendar exports work (tested), deleting old calendars may or may not work (probably works) but also its probably negligible storage |
…essing for schedules, and add configuration for function timeout and memory size in sst.config.ts.
Enhance refreshCals function with improved error handling, batch processing for schedules, and add configuration for function timeout and memory size in sst.config.ts.
|
this has been pushed to prod for a while now, verified calendars update |
1 participant
No description provided.