Open
Conversation
delete build folder
update: cocoapod version
hcn1519
reviewed
Jun 24, 2018
| scrollView.contentInsetAdjustmentBehavior = .never | ||
| scrollImageView = UIImageView(frame: CGRect(x: 0, y: 0, | ||
| width: scrollView.frame.width, | ||
| height: scrollView.frame.height)) |
Contributor
There was a problem hiding this comment.
scrollImageView = UIImageView(frame: CGRect(origin: .zero, size: scrollView.frame.size))This style looks better for minimizing code.
| } | ||
| required public init?(coder aDecoder: NSCoder) { | ||
| super.init(coder: aDecoder) | ||
| } |
Contributor
There was a problem hiding this comment.
Is THMinimapViewcan still be used from storyboard with setUp(scrollView:downSizeRatio:image:minimapImage) ?
Call default setUp()function, or you should handle required property from another function.(not from init)
For example,
let minimapView = THMinimapView()
minimapView.setup(scrollView: scrollView, downSizeRatio: downSizeRatio, image: image, minimapImage: minimapImage)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete minimap datasource (because the data is not dynamic, just need to set the data when init the minimap view)
just need to init minimap view and pass the scroll view, image, downsize ratio for the size of minimap view compared to scroll view and selectively, the minimap image if the image for the minimap is different from the image of the scroll view.