chore: Dead-Code entfernen (90 Funde, 4-fach cross-model-verifiziert)#70
Open
TillQuandel wants to merge 1 commit into
Open
chore: Dead-Code entfernen (90 Funde, 4-fach cross-model-verifiziert)#70TillQuandel wants to merge 1 commit into
TillQuandel wants to merge 1 commit into
Conversation
Entfernt 90 statische-Analyse-Funde (ruff F401/F811/F841 + vulture): - 84 ungenutzte Imports (sys/Path/json/re/numpy/dup-Imports) - verwaiste config-Importe: ER_BLOCKING_JACCARD (deprecated), CACHE_DIR, EVAL_ADAPTIVE_K_*, WISSEN, lru_cache, print_summary - tote Variablen: confirmed (kommt aus decision_engine.aggregate), seen_orders (Re-Def-Schutz läuft bereits über pairs), ungenutztes except-e - unreachable `return None` in vault_writer._find_source_note Geschützt (NICHT entfernt, als ABSICHT verifiziert): - generative/agents/base.py: _RUN_ID Re-Export (extern in orchestrator, eval_quality, reeval_baseline genutzt) -> # noqa: F401 - test_tag_whitelist.py: 6 lokale Path-Importe (in Tests genutzt) Verifikation: Claude + Mistral + Codex + Tool-Subagent (Union, nicht Voting). Tests vor/nach identisch: 4697 passed, 3 skipped. ruff clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
Entfernt 90 statische-Analyse-Funde (ruff F401/F811/F841 + vulture) in
generative/,extractive/,lib/,shared/:sys/Path/json/re/numpy, Duplikate)ER_BLOCKING_JACCARD(laut config.py deprecated),CACHE_DIR,EVAL_ADAPTIVE_K_*,WISSEN,lru_cache,print_summaryconfirmed(Kennzahl kommt ausdecision_engine.aggregate),seen_orders(Re-Def-Schutz läuft bereits überpairs), ungenutztesexcept … as ereturn Noneinvault_writer._find_source_noteBewusst NICHT entfernt (als Absicht verifiziert)
generative/agents/base.py:_RUN_IDRe-Export — extern genutzt in orchestrator (4×), eval_quality, reeval_baseline, eval_quality_v4. Blindesruff --fixhätte das gelöscht und drei Module gebrochen. Jetzt mit# noqa: F401dokumentiert.test_tag_whitelist.py: 6 lokalePath-Importe (in den Test-Funktionen genutzt) — nur der ungenutzte Top-Level-Import entfernt.Verifikation
Jeder Fund klassifiziert durch 4 unabhängige Reviewer (Claude, Mistral, Codex, Tool-Subagent), Union statt Mehrheitsvotum. Kein blindes Auto-Fix.
ruff check --select F401,F811,F841,F823: All checks passed