Less opinionated template#1
Less opinionated template#1Sinetheta wants to merge 2 commits intoTimHeckel:masterfrom Sinetheta:less-opinionated
Conversation
|
I certainly agree with pulling the styles out and removing the results per page label div...along these same lines, it would make sense to allow users to populate the result per page values themselves (rppOptions: [5, 10, 15, 20, 30, 50, 100, etc])...any chance you'd like to add that to your PR ? I'll merge :) |
|
Sure, but that leads to another discussion, deep options. Since the options hash is itself made up of objects and _.extend is not recursive, setting only "some" of a nested option will crush the others. For example:
as in your example will overwrite Those options should really be broken out on their own, instead of nested. But then that leads to the discussion about how much of this should be encapsulated within the |
Removed "pull-right"s, the "results per page" div, and cleaned some whitespace. Those are probably best left to the user.