Address reviewer baseline and communication-cost concerns#1
Open
TomasOrtega wants to merge 16 commits into
Open
Address reviewer baseline and communication-cost concerns#1TomasOrtega wants to merge 16 commits into
TomasOrtega wants to merge 16 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the reviewer-requested experiment, communication-cost, manuscript, and rebuttal work on the
review-response-experimentsbranch.Changes now include:
run_simulation, including DECO-i(wealth, G)versus DECO-iiG-only messages.experiments/run_review_baseline_experiment.py.experiments/run_review_real_data_experiment.py.RealDataEnvironmentfordiabetes,breast_cancer,digits,wine, andlinnerud, while preserving the existing LIBSVM datasets.seedargument.run_all.shandrun_all.batinclude both review experiments.tex/main.texnow injects focused reviewer-driven additions into the experiments section while preserving the original manuscript body astex/main_original.tex.tex/rebuttal/review_response.texnow directly answers each reviewer concern with communication accounting, adaptive baselines, real-data results, DECO-i/DECO-ii communication normalization, notation/potential-function caveats, and convex-scope limitations.Validation performed
I ran the review experiments locally from a reconstructed working tree because the execution container could not clone from GitHub directly.
Synthetic review run:
Real-data review runs, split per dataset to avoid the tool timeout:
I also syntax-tested the manuscript wrapper mechanism with a local minimal LaTeX fixture to confirm that the added
review_revision_*.texfiles are inserted at the intended subsection hooks.The results support a more careful rebuttal: the adaptive baselines are competitive or stronger in these short-horizon/tuned settings, while DECO-i generally outperforms DECO-ii at the cost of one additional scalar per directed neighbor exchange. The text therefore avoids overclaiming empirical dominance and emphasizes the parameter-free learning-rate guarantee, explicit communication accounting, and convex-online-learning scope.
Remaining note
The branch now contains
tex/as ordinary files rather than a submodule. I have not merged this PR.