Bomb Rad Suit#142
Conversation
github-actions
Bot
added
S: Untriaged
size/S
YML
No C#
mnva0
left a comment
mnva0
left a comment
There was a problem hiding this comment.
Thank you for this PR! Just a few things I noticed. Please ask me if you want me to elaborate on anything
| @@ -0,0 +1 @@ | |||
| lathe-category-AdvancedSuitsRecipe = Advanced Suits | |||
There was a problem hiding this comment.
Conventions say that all FTL IDs should be in kebab-case-as-in-dashes-as-spaces-I-believe and must never contain capital letters
| research-technology-civilian-stash = Civilian Ship Stash | ||
| research-technology-military-stash = Military Ship Stash No newline at end of file | ||
| research-technology-military-stash = Military Ship Stash | ||
| research-technology-Suits-Advanced = Advanced Suits |
There was a problem hiding this comment.
Conventions say that all FTL IDs should be in kebab-case-as-in-dashes-as-spaces-I-believe and must never contain capital letters
| technologyPrerequisites: | ||
| - HardsuitsSpecialized | ||
| position: 1, 7 | ||
| position: 2, 7 |
There was a problem hiding this comment.
Triad changes must have comments
| @@ -0,0 +1,42 @@ | |||
| - type: latheRecipe | |||
| id: SuitsAdvancedRecipe | |||
| abstract: true | |||
There was a problem hiding this comment.
Conventions state that abstract must always come first. Directly under type as the first entry in the list
There was a problem hiding this comment.
Also, why is this a new latheRecipe? It doesn't seem to have much of a reason to exist as a parent since it doesn't seem to define anything. There is probably some common stuff between the suits you could add here if you'd like. categories maybe?
|
|
||
| - type: latheRecipe | ||
| id: ClothingOuterSuitRad | ||
| parent: SuitsAdvancedRecipe |
|
|
||
| - type: latheRecipe | ||
| id: ClothingHeadHelmetBombSuit | ||
| parent: SuitsAdvancedRecipe |
|
|
||
| - type: latheRecipe | ||
| id: ClothingOuterSuitBomb | ||
| parent: SuitsAdvancedRecipe |
| coefficients: | ||
| Heat: 0.90 | ||
| Radiation: 0.01 | ||
| Radiation: 0 |
There was a problem hiding this comment.
Triad changes must be marked
| Heat: 0.75 | ||
| - type: ExplosionResistance | ||
| damageCoefficient: 0.15 | ||
| damageCoefficient: 0.05 |
There was a problem hiding this comment.
Triad changes must be marked
There was a problem hiding this comment.
Assuming this does what I think it does: I don't think we need a dedicated category for a couple items? This adds a new dropdown selection to lathes, right? Please do correct me if I'm wrong
There was a problem hiding this comment.
it adds a new category for the protolathe to make i understand, I'm at work rn so I'll check it and fix most of it when i get home
|
Also: The bombsuit reduces damage by 95% as in that picture and the helmet reduces damage by 10%. Wouldn't this make people completely immune to explosion damage? Worth checking and I believe we don't want total immunity. I have not actually asked the other maintainers but complete bomb resistance might be a slight balancing problem |
The damage reduction shouldn't work like that. The suit reduces the damage down by 95% then the helmet takes the remaining 5% and reduces that by 10% making the total damage reduction from explosions to be 95.5% with both equipped. |
|
Thank you for correcting me then. I'll leave considering the balance implications to another maintainer better at balancing |
|
gimme a sec i fixed it too quickly and it's missing stuff- |
|
Fix linter failing |
4 participants
About the PR
Added a new research tree and folders for triad, the radsuit and bomb suit were buffed and able to be crafted
Why / Balance
The bombsuit and rad suit are useless for their special gimmick due to the fact the CE/RD suit makes it way better and also is space proof
Media
Requirements
How to test
get research and unlock it, then make it on a protolathe
Breaking changes
None Found
Changelog
🆑