Mla79 Overhaul#176
Conversation
github-actions
Bot
added
size/M
C#
YML
Sprites
FTL
|
RSI Diff Bot; head commit 4704f2a merging into 68826b4 Resources/Textures/_Triad/Clothing/Belt/mla79harness.rsi
|
|
The curse of the build and test debug |
|
Try merging master, I merged the test improvements PR |
|
you mean merge it to my master then merge again? or just remake the PR? |
Merge master to your PR |
|
gotcha one sec |
|
|
||
| # Ranged Weapons | ||
| - type: Tag | ||
| id: MachinePistol |
There was a problem hiding this comment.
so i forgot to take this out when i moved this MLA 79 project to its own branch, this was for some holster things i was working on and plan to PR soon.
|
Hm this is interesting.. can see that being applied for future energy weapons, i.e. the turbolaser (which is still kinda in a sorry state considering its a very low drop chance from AI mobs) or even other ballistics (something something 5 or 6 barrels, rotating..). Wonder if this system can be applied to a gun e.g. a gun needs both magazine and power supply, think a railgun or gauss rifle.. Very cool ngl |
I need to clean up some of the C# stuff like the event and component names to be shorter and easier to work with before i'm totally comfortable with the PR being merged, mostly submitted to get feedback. For the railgun idea with the weapon requiring both ammo and a power source i'm not sure if the game can do that as of right now, may need some light c# work. Maybe crossing the laser weapon code with ballistic stuff may get that? I know a yaml for it would just have an extra type container slot for power cells, so that front wont really be hard. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
DDrakov
left a comment
DDrakov
left a comment
There was a problem hiding this comment.
The text can be better, GUN READY is too weird
What's the point of having the harness if it can't put anything in it? maybe makes it so you can put spare batteries or some mag itself.
|
|
Otherwise, solid PR it works as intended. |
You want it to be smaller?
That's weird, It must be something to do with the power cell stuff since the harness is now a 'container' as well as a belt, I'll work on this when I get home. |
nah, just change the name maybe. Like make it more pleasant to see rather than "GUN READY", I'm unsure how FTL works so maybe could ask Ricky or Boba in the contributor, like "the gun is ready" I think the issue is that whitelist tag, having that that meaning it's only whitelisted for that specific item/proto |
Does 'Weapon Linked' sound better? Also while at work my interenet is trash so It'll be hard to use discord reliably. Yea i caught the whitelist part, should be an easy fix, I think i was just so focused on the harness working right with the cells and weapon I forgot to put stuff in it to see if it actually functioned as a belt. |
Funny bug, if you alt+click on the harness you can't instantly took out the battery as you also trigger the magnetic harness
|
DDrakov
left a comment
DDrakov
left a comment
There was a problem hiding this comment.
Good enough to run, the concept is great approval from me.
i was not notified of this via email so sorry for the late reply. I'm not sure how to fix that as of right now other than removing the magnet action as a hotkey-able thing |
4 participants
About the PR
Adds 'Powered Weapon Harness' functionality to the fork. Includes a MLA-79 Harness which is now intended to be utilized with the MLA-79 Smartgun.
Why / Balance
The Smartgun canonically (at least from Aliens) is supposed to have an arm mount and a harness to function correctly, the fork did not emulate the harness part of the system so this PR was created to address that.
The harness was implemented in a generalized manner so it will allow future contributors to make their own 'heavy weapons' which may be better balanced by them utilizing such a system. It functions rather simply.
'Heavy Weapons' can be used without the harness, however the player will suffer movement and accuracy penalties regardless if it is wielded, in hand, or on the players back/suitslot.
If a player has the correct harness for their chosen weapon, and the harness has a charged power cell, it will restore the players movement speed to 'default', and will provide accuracy bonus the gun had already prior to this PR, wielded movement speed is reduced for balance. So long as the player is in possession of their weapon, it will passively drain from the harnesses power cell, every shot from the weapon will also drain the power cell by 5 until depleted. There are audio alerts upon the weapon linking to the harness, the harness being at half charge, and the harness charge being depleted. The harness also features a retrieval system that if the harness has power it will retrieve the weapon and return it to the suitstorage slot. This feature is toggleable.
Upon power depletion, the harness will no longer provide benefits to the player and their weapon, they may as well not even be wearing it until they recharge it. Antique Power Cells are blacklisted from the harness slot because they're too over powered. Weapon retrieval will also not occur if the harness is not powered.
Media
Requirements
How to test
Acquire a MLA-79 Harness with a charged power cell (Antique Blacklisted)
Acquire a MLA-79 Smartgun
Pick up the Smartgun while wearing the harness, it should say 'GUN READY' and emit a beep.
Move and fire with the weapon.
When the harness battery is depleted, remove power cell and recharge.
Breaking changes
Changelog
🆑