Adding a High Damage Sound to CrewMonitoringConsoleComponents#192
Adding a High Damage Sound to CrewMonitoringConsoleComponents#192SomeoneElsHere wants to merge 35 commits into
Conversation
This reverts commit 07561df.
//yeah I dont like how this method turned out but... (sigh)
//it does the following:
//Over 100 damage? Play a sound.
//Over 128 crew consoles? Start skipping everything to preservere resourses.
//Dont play that sound if it is in a 15 radius of another crew monitor.
//Dont play that sound if there is a cooldown.
TheRealMasterChief117
left a comment
There was a problem hiding this comment.
Above reviews
|
Thank you for the review! I'm pretty new to this so this is really helpful! Ill get to it as fast as I can |
Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
|
There is an issue with the playing sound though, playPVS just doesn't want to work. Any ideas? |
Repeat |
…tem.cs Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…mputers.yml Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…mputers.yml Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…d_crew_monitor.yml Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…d_crew_monitor.yml Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
Thank you for all your help! Ill try and use this as a base for conventions if I add anything in the future |
|
Also for some future planning. If there is ever an issue if sound spamming try raising the damage threshold. |
|
I think it might be bugged in release lemme check |
|
Is fixed in next pr commit, say thank you to RICKY |
About the PR
The PR does the following.
Why / Balance
Currently, the only thing telling med how bad a situation is besides going there themselves is the interval between comms death and crit announcements. Adding a noise to when someone dies in a horrible accident adds initiative and dread. You don't know what just happened, but you know it's bad. It could be harmless, or it could be something way, way worse.
Also having confirmation from the game that "Yea, you had no chance there buddy" is pretty funny.
Media
MedHudDamage_Showcase.webm
MedHudDamage6_ MessagingSystem.webm
Requirements
How to test
Get either a Crew Monitoring Console or a Handheld Crew-Monitoring Console.
Get to 100+ damage from a source (can be multiple if it chain reacts, i.e. Explosive Grenade)
NOTES:
The sound is pretty quiet, so you might not hear it if there is an explosion.
SURFACE LEVEL TESTING SUGGESTION:
Get a gun.
Get a handheld crew monitor.
Execute yourself with the crew monitor nearby or in your pocket.
Breaking changes
Changelog
🆑
Future Notes
If there is a problem with sound spamming, raise the damage threshold.