Skip to content

Adding a High Damage Sound to CrewMonitoringConsoleComponents#192

Open
SomeoneElsHere wants to merge 35 commits into
Triad-Sector:mainfrom
SomeoneElsHere:Branch100
Open

Adding a High Damage Sound to CrewMonitoringConsoleComponents#192
SomeoneElsHere wants to merge 35 commits into
Triad-Sector:mainfrom
SomeoneElsHere:Branch100

Conversation

@SomeoneElsHere

@SomeoneElsHere SomeoneElsHere commented Jun 8, 2026

Copy link
Copy Markdown

About the PR

The PR does the following.

 A. Over 100 damage? Play a sound to add to overall dread (Explained More In Why)
    This adds a noise to CrewMonitoringConsoleComponents (Handheld med console and regular, not admin)
    when any crew gets hurt to a huge attack (100+ damage in one attack). 

 B. Over 128 crew consoles? Start skipping everything to preserve resourses.
     Stops the sound from playing at any more consoles than 128 (first come, first serve).

 C. Dont play that sound if it is in a 15 radius of another crew monitor to stop really loud sounds.
      Stops abuse from getting a ton of handhelds and just obliterating everyone's eardrums.

 D. Dont play that sound if there is a cooldown to stop really loud sounds.
      Stops abuse from getting hit a ton and triggering the consoles over and over. Can change the delay from 1000ms to
      something longer.

 E. No sounds if we dont have a sensor; how would the crew console get it IC?
     If you are not crew, or you dont have a sensor applied, the sound does not play when you get hit by a truck.

 F. The crew monitoring system tells you who has been fatally damaged, so that you already know before checking.

Why / Balance

Currently, the only thing telling med how bad a situation is besides going there themselves is the interval between comms death and crit announcements. Adding a noise to when someone dies in a horrible accident adds initiative and dread. You don't know what just happened, but you know it's bad. It could be harmless, or it could be something way, way worse.

Also having confirmation from the game that "Yea, you had no chance there buddy" is pretty funny.

Media

MedHudDamage_Showcase.webm
MedHudDamage6_ MessagingSystem.webm

Requirements

  • [ X] I have read relevant guidelines/documentation to this PR found on our devwiki.
  • [X ] I have added media to this PR or it does not require an ingame showcase.
  • [ X] I can confirm this PR contains either no AI-generated content, or AI-generated content that meets our guidelines.

How to test

Get either a Crew Monitoring Console or a Handheld Crew-Monitoring Console.
Get to 100+ damage from a source (can be multiple if it chain reacts, i.e. Explosive Grenade)
NOTES:
The sound is pretty quiet, so you might not hear it if there is an explosion.
SURFACE LEVEL TESTING SUGGESTION:
Get a gun.
Get a handheld crew monitor.
Execute yourself with the crew monitor nearby or in your pocket.

Breaking changes

Changelog
🆑

  • add: Added a noise and message to Handheld/Non-Handheld Crew Monitoring Consoles if you gain 100+ damage at once.

Future Notes

If there is a problem with sound spamming, raise the damage threshold.

//yeah I dont like how this method turned out but... (sigh)
    //it does the following:
    //Over 100 damage? Play a sound.
    //Over 128 crew consoles? Start skipping everything to preservere resourses.
    //Dont play that sound if it is in a 15 radius of another crew monitor.
    //Dont play that sound if there is a cooldown.
@Triad-Sector Triad-Sector changed the title Adding a high damage sound to CrewMonitoringConsoleComponents Adding a High Damage Sound to CrewMonitoringConsoleComponents Jun 8, 2026
@SomeoneElsHere SomeoneElsHere marked this pull request as ready for review June 8, 2026 06:10
Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs Outdated
Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs Outdated
Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs Outdated
Comment thread Content.Server/Sound/EmitSoundSystem.cs Outdated
Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs Outdated

@TheRealMasterChief117 TheRealMasterChief117 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above reviews

@SomeoneElsHere

SomeoneElsHere commented Jun 8, 2026

Copy link
Copy Markdown
Author

Thank you for the review! I'm pretty new to this so this is really helpful! Ill get to it as fast as I can

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
@github-actions github-actions Bot added the size/M label Jun 8, 2026
@SomeoneElsHere

SomeoneElsHere commented Jun 9, 2026

Copy link
Copy Markdown
Author

There is an issue with the playing sound though, playPVS just doesn't want to work. Any ideas?
EDIT: I don't think it is the pvs anymore, its probably something else

Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs Outdated
Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleComponent.cs Outdated
Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs Outdated
Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs Outdated
Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs Outdated
Comment thread Resources/Audio/Machines/attributions.yml Outdated
Comment thread Resources/Audio/Machines/attributions.yml
Comment thread Resources/Prototypes/Entities/Structures/Machines/Computers/computers.yml Outdated
Comment thread Resources/Prototypes/Entities/Structures/Machines/Computers/computers.yml Outdated
@TheRealMasterChief117

Copy link
Copy Markdown
Collaborator

Looks good other than those nitpicks. I apologize for the many amounts of reviews, but we need to ensure the code is up to standard!

Thanks for the PR, this should be merged soon once the last reviews are complete.

Repeat

SomeoneElsHere and others added 13 commits June 11, 2026 13:53
…tem.cs

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…mputers.yml

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…mputers.yml

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…tem.cs

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…d_crew_monitor.yml

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
…d_crew_monitor.yml

Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
Comment thread Content.Server/Medical/CrewMonitoring/CrewMonitoringConsoleSystem.cs Outdated
@SomeoneElsHere

Copy link
Copy Markdown
Author

Looks good other than those nitpicks. I apologize for the many amounts of reviews, but we need to ensure the code is up to standard!
Thanks for the PR, this should be merged soon once the last reviews are complete.

Repeat

Thank you for all your help! Ill try and use this as a base for conventions if I add anything in the future

@SomeoneElsHere

Copy link
Copy Markdown
Author

Also for some future planning.

If there is ever an issue if sound spamming try raising the damage threshold.

@SomeoneElsHere

SomeoneElsHere commented Jun 12, 2026

Copy link
Copy Markdown
Author

I think it might be bugged in release lemme check
Edit: Yep the sound doesnt work but the message does

@SomeoneElsHere

Copy link
Copy Markdown
Author

Is fixed in next pr commit, say thank you to RICKY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants