Skip to content

docs: contributing.md#8

Draft
GodderE2D wants to merge 1 commit into
mainfrom
GodderE2D-patch-contributing
Draft

docs: contributing.md#8
GodderE2D wants to merge 1 commit into
mainfrom
GodderE2D-patch-contributing

Conversation

@GodderE2D

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Mar 9, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web ❌ Failed (Inspect) Mar 9, 2023 at 6:34PM (UTC)

@GodderE2D

Copy link
Copy Markdown
Member Author

how did ci fail

@tristancamejo

Copy link
Copy Markdown
Contributor

how did ci fail

Vercel preview prs are disabled since we don’t have a set of staging api keys

Comment thread CONTRIBUTING.md
- Yarn classic (v1)
- MySQL database
- JDK/Java 17
- Discord dev OAuth app

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discord Application

Comment thread CONTRIBUTING.md

Fill in your environment variables according to the [`.env.example`](https://github.com/TristanSMP/gateway/blob/main/.env.example).

The `ELYTRA_API_ROOT` environment variable should **not** including a trailing slash.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `ELYTRA_API_ROOT` environment variable should **not** including a trailing slash.
The `ELYTRA_API_ROOT` environment variable should **not** include a trailing slash.

@tristancamejo

tristancamejo commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

@GodderE2D any updates on this? Will you be finishing the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants