Changed ci/cd to support second pub/sub topic#867
Conversation
WalkthroughThe CI/CD workflow configuration was modified to split the single environment variable Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ref https://linear.app/ghost/issue/PROD-1953 - Changed ci/cd to support the second pub/sub topic. Includes deployments to two new services: ghost-queue and fedify-queue.
rmgpinto
force-pushed
the
cicd-pubsub-second-topic
branch
from
8c83c21 to
e68a3f9
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
.github/workflows/cicd.yml (2)
451-460: Duplicate of staging Fedify queue logic
Thestg-*-activitypub-ghost-queuedeploy block is structurally identical to the Fedify step above. Consider the same refactor suggestion to DRY these two blocks via a loop or anchors.
542-550: Duplicate of production Fedify queue logic
Thisprd-*-activitypub-ghost-queuestep repeats the same structure. Apply the same DRY refactor for consistency.
🧹 Nitpick comments (2)
.github/workflows/cicd.yml (2)
441-450: Consider DRYing the staging queue deployments
The new step forstg-${{ matrix.region_name }}-activitypub-fedify-queuelooks correct, but it nearly duplicates the existing queue deploy block. You could consolidate all queue service names into a matrix or use YAML anchors to reduce repetition.
532-540: DRY up production Fedify queue step
Theprd-${{ matrix.region_name }}-activitypub-fedify-queuedeployment mirrors the existing queue block. Extract the queue names to a matrix or YAML anchor to avoid copy-pasting.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/cicd.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build, Test and Push
🔇 Additional comments (1)
.github/workflows/cicd.yml (1)
309-310: Ensure Terraform modules consume the new variables
You’ve splitTF_VAR_queue_imageintoTF_VAR_fedify_queue_imageandTF_VAR_ghost_queue_image, which aligns with the new services. Double-check that your Terraform configs (e.g. in the staging and production environment folders of the infra repo) declare and use these variables so they actually drive the new deployments.
1 participant
ref https://linear.app/ghost/issue/PROD-1953