Skip to content

Update Vietnamese - portal.json#26913

Open
honhatduy wants to merge 2 commits intoTryGhost:mainfrom
honhatduy:patch-2
Open

Update Vietnamese - portal.json#26913
honhatduy wants to merge 2 commits intoTryGhost:mainfrom
honhatduy:patch-2

Conversation

@honhatduy
Copy link
Contributor

Added the lastest strings.

Added the lastest strings.
@cursor
Copy link

cursor bot commented Mar 22, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7ca2df54-1fc0-4462-8d70-b664644376a7

📥 Commits

Reviewing files that changed from the base of the PR and between 14b06f5 and ff99f16.

📒 Files selected for processing (1)
  • ghost/i18n/locales/vi/portal.json

Walkthrough

This change updates the Vietnamese locale file ghost/i18n/locales/vi/portal.json by replacing many previously-empty entries with Vietnamese translations. Added translations cover duration/month phrasing, promo/subscription CTAs with placeholders, billing/Stripe/checkout error messages, RSS and newsletter labels, spam-folder wording and provider labels, subscription status and cancellation messages, and sample contact data. File diff: +42/−42 lines.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update Vietnamese - portal.json' accurately describes the main change: updating Vietnamese translations in the portal.json file.
Description check ✅ Passed The description 'Added the lastest strings' is related to the changeset, referring to adding/updating translation strings in the Vietnamese locale file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
ghost/i18n/locales/vi/portal.json (1)

38-38: Consider normalizing “spam/Spam” casing across related messages.

There’s mixed casing for the same concept (e.g., spam, Spam) in nearby guidance strings. Standardizing this improves translation consistency and tone.

Also applies to: 111-111, 123-123, 138-138, 208-208

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ghost/i18n/locales/vi/portal.json` at line 38, The translated string for
"Check spam & promotions folders" uses mixed casing for "spam" ("thư mục spam &
quảng cáo") while nearby messages use "Spam" — normalize casing to one form
(prefer lowercase "spam") across all related keys (e.g., the "Check spam &
promotions folders" key and the other related message keys mentioned) by
updating their Vietnamese translations so they consistently use the same
capitalization for "spam" and "promotions"/"quảng cáo".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ghost/i18n/locales/vi/portal.json`:
- Line 78: The Vietnamese translation entries for the English key "Enjoy a free
month on us." (value currently "Tận hưởng một tháng đọc miễn phí") and the other
adjacent variant missing a trailing period should be updated to include a
sentence-ending period for consistency with their paired variants; find the JSON
entries whose keys match "Enjoy a free month on us." and the other similar key
and append a trailing "." to their translated values so all UI copy variants
consistently end with a period.

---

Nitpick comments:
In `@ghost/i18n/locales/vi/portal.json`:
- Line 38: The translated string for "Check spam & promotions folders" uses
mixed casing for "spam" ("thư mục spam & quảng cáo") while nearby messages use
"Spam" — normalize casing to one form (prefer lowercase "spam") across all
related keys (e.g., the "Check spam & promotions folders" key and the other
related message keys mentioned) by updating their Vietnamese translations so
they consistently use the same capitalization for "spam" and "promotions"/"quảng
cáo".

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f1dfd71d-1656-4522-86d6-d2aa35438c7a

📥 Commits

Reviewing files that changed from the base of the PR and between 248fe42 and 14b06f5.

📒 Files selected for processing (1)
  • ghost/i18n/locales/vi/portal.json

Add the missing periods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant