Skip to content

Removed app from npm package#741

Merged
troyciesco merged 1 commit intomainfrom
rm-app-from-npm-pkg
Mar 16, 2026
Merged

Removed app from npm package#741
troyciesco merged 1 commit intomainfrom
rm-app-from-npm-pkg

Conversation

@troyciesco
Copy link
Contributor

ref #730

  • when users do something like npm i gscan, they're currently including the files for the web app at gscan.ghost.org when they do that
  • this removes app from the files list, so now when things are packaged up for npm it only includes lib and bin
  • this should have no impact on the web app
  • this should significantly improve gscan's package size. npm pack --dry-run shows the following:
Package size Unpacked size
Before 596.8 kB 950.5 kB
After 56.0 kB 320.5 kB

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eb2537c4-4246-4819-bb76-b48ac09c6b46

📥 Commits

Reviewing files that changed from the base of the PR and between 8443ca1 and 538e372.

📒 Files selected for processing (1)
  • package.json

Walkthrough

The "app" entry was removed from the "files" array in package.json. The array now contains only "lib" and "bin" instead of the previous "lib", "bin", and "app".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing 'app' from the npm package's files array, which is the primary objective of the pull request.
Description check ✅ Passed The description is directly related to the changeset, providing context about why the 'app' entry was removed, the impact on package size, and references the associated issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rm-app-from-npm-pkg
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting to assertive to make CodeRabbit's nitpick more issues in your PRs.

@troyciesco troyciesco merged commit 73bc1ab into main Mar 16, 2026
4 checks passed
@troyciesco troyciesco deleted the rm-app-from-npm-pkg branch March 16, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant