Skip to content

Added missing knownHelpers for Ghost v6 helpers#742

Merged
ErisDS merged 1 commit intomainfrom
add-missing-known-helpers
Mar 17, 2026
Merged

Added missing knownHelpers for Ghost v6 helpers#742
ErisDS merged 1 commit intomainfrom
add-missing-known-helpers

Conversation

@ErisDS
Copy link
Member

@ErisDS ErisDS commented Mar 17, 2026

Summary

  • Added json, color_to_rgba, contrast_text_color to v6 knownHelpers — new helpers introduced in Ghost's private page feature (Ghost PR #26762)
  • Added raw and search — pre-existing Ghost helpers that were missing from gscan's knownHelpers

Without these, themes using any of these helpers get false "unknown helper" warnings during validation.

Context

Ghost has a cross-reference test that verifies all theme-facing helpers in core/frontend/helpers/ are present in gscan's knownHelpers. That test currently fails for these 5 helpers, blocking merge until this gscan update lands.

Added json, color_to_rgba, contrast_text_color (new in Ghost private
page feature), plus raw and search which were pre-existing gaps.
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: abfae839-6212-4a3e-9091-1c636905ac66

📥 Commits

Reviewing files that changed from the base of the PR and between 65b3062 and 88a0dc7.

📒 Files selected for processing (1)
  • lib/specs/v6.js

Walkthrough

The pull request expands the knownHelpers array in lib/specs/v6.js by adding five new helper function names: json, color_to_rgba, contrast_text_color, raw, and search. The array previously contained only ['split'] and now includes these additional helpers, representing a single line modification to the specification file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding five missing helpers to the knownHelpers set in Ghost v6 specifications.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific helpers added and the rationale for the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-missing-known-helpers
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

ErisDS added a commit to JohnONolan/Ghost that referenced this pull request Mar 17, 2026
Removed raw and search from internalHelpers exclusion list — they
should be in gscan knownHelpers. Test now fails for all 5 helpers
pending gscan PR: TryGhost/gscan#742
@ErisDS ErisDS merged commit e6770c3 into main Mar 17, 2026
4 checks passed
@ErisDS ErisDS deleted the add-missing-known-helpers branch March 17, 2026 19:39
ErisDS added a commit to JohnONolan/Ghost that referenced this pull request Mar 18, 2026
Removed raw and search from internalHelpers exclusion list — they
should be in gscan knownHelpers. Test now fails for all 5 helpers
pending gscan PR: TryGhost/gscan#742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant