Added missing knownHelpers for Ghost v6 helpers#742
Merged
Conversation
Added json, color_to_rgba, contrast_text_color (new in Ghost private page feature), plus raw and search which were pre-existing gaps.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request expands the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
ErisDS
added a commit
to JohnONolan/Ghost
that referenced
this pull request
Mar 17, 2026
Removed raw and search from internalHelpers exclusion list — they should be in gscan knownHelpers. Test now fails for all 5 helpers pending gscan PR: TryGhost/gscan#742
ErisDS
added a commit
to JohnONolan/Ghost
that referenced
this pull request
Mar 18, 2026
Removed raw and search from internalHelpers exclusion list — they should be in gscan knownHelpers. Test now fails for all 5 helpers pending gscan PR: TryGhost/gscan#742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json,color_to_rgba,contrast_text_colorto v6 knownHelpers — new helpers introduced in Ghost's private page feature (Ghost PR #26762)rawandsearch— pre-existing Ghost helpers that were missing from gscan's knownHelpersWithout these, themes using any of these helpers get false "unknown helper" warnings during validation.
Context
Ghost has a cross-reference test that verifies all theme-facing helpers in
core/frontend/helpers/are present in gscan'sknownHelpers. That test currently fails for these 5 helpers, blocking merge until this gscan update lands.