Update documentation versions and expand learning path #84
Conversation
- Updated `docs/GETTING_STARTED.md` and `docs/cookbook/src/getting_started/installation.md` to reference the current version `0.1.233`. - Expanded `docs/cookbook/src/learning/README.md` with an internal learning path. - Added usage examples to `docs/cookbook/src/crates/rustapi_jobs.md` (Background Jobs). - Added `insight` feature documentation to `docs/cookbook/src/crates/rustapi_extras.md`. Co-authored-by: Tuntii <121901995+Tuntii@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Updates RustAPI documentation to align with workspace version 0.1.233 and expands the cookbook learning materials, including new guidance for rustapi-jobs and the insight feature in rustapi-extras.
Changes:
- Updated installation/version snippets across docs to reference
0.1.233. - Added a structured “Cookbook Internal Path” to guide readers through key topics.
- Expanded crate docs with new examples/feature docs for
rustapi-jobsandrustapi-extras(insight).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/cookbook/src/learning/README.md | Adds an internal cookbook reading path to guide new users. |
| docs/cookbook/src/getting_started/installation.md | Adds instructions for manually adding rustapi-rs to an existing project (pinned version). |
| docs/cookbook/src/crates/rustapi_jobs.md | Expands rustapi-jobs documentation with a more detailed usage example and feature descriptions. |
| docs/cookbook/src/crates/rustapi_extras.md | Documents the insight feature and adds a new feature-flag table entry. |
| docs/GETTING_STARTED.md | Updates rustapi-rs version references and feature examples to 0.1.233. |
| - **Exponential Backoff**: Automatically retries failing jobs with increasing delays. | ||
| - **Dead Letter Queue (DLQ)**: "Poison" jobs that fail repeatedly are isolated for manual inspection. | ||
| - **Concurrency Control**: Limit the number of concurrent workers to prevent overloading your system. |
There was a problem hiding this comment.
The docs claim built-in DLQ and concurrency controls, but rustapi-jobs currently only implements retries with exponential backoff; DLQ is explicitly marked TODO in crates/rustapi-jobs/src/queue.rs, and there is no concurrency configuration in the crate. Please adjust this section to reflect the current behavior (or clearly mark DLQ/concurrency as planned/future work).
|
|
||
| ### 1. Define the Job | ||
|
|
||
| Jobs are simple structs that implement `Serialize` and `Deserialize`. |
There was a problem hiding this comment.
The text suggests a job is just a serializable struct, but in rustapi-jobs the Job trait is implemented by a handler type with an associated Data payload type (the payload is what needs Serialize/Deserialize). Update this description to match the actual API so readers don’t model jobs incorrectly.
| // 5. Enqueue a job | ||
| queue.enqueue(EmailJob { | ||
| to: "user@example.com".into(), | ||
| subject: "Welcome!".into(), | ||
| body: "Thanks for joining.".into(), | ||
| }).await?; |
There was a problem hiding this comment.
JobQueue::enqueue takes the job’s Data payload and is generic over the job type (e.g., enqueue::<EmailJob>(data)), returning a job id String. Enqueuing the handler struct (queue.enqueue(EmailJob { ... })) doesn’t match the actual API in crates/rustapi-jobs/src/queue.rs and won’t compile.
| ## Adding to an Existing Project | ||
|
|
||
| If you prefer not to use the CLI, you can add RustAPI to your `Cargo.toml` manually: | ||
|
|
||
| ```bash | ||
| cargo add rustapi-rs@0.1.233 | ||
| ``` |
There was a problem hiding this comment.
This new section pins rustapi-rs to 0.1.233, but the earlier CLI install command in this same doc installs whatever the latest cargo-rustapi is. To keep the installation guide consistent with the “match workspace version” goal, consider pinning cargo install cargo-rustapi --version 0.1.233 (or explicitly note the recommended compatible CLI version).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t panic - Updated `docs/GETTING_STARTED.md` and `docs/cookbook/src/getting_started/installation.md` to reference version `0.1.233`. - Expanded `docs/cookbook/src/learning/README.md` with an internal learning path. - Added code examples to `docs/cookbook/src/crates/rustapi_jobs.md` and documentation for `insight` in `rustapi_extras`. - Fixed a panic in `rustapi-extras` property tests (`oauth2::tokens::property_tests::prop_token_expiration_tracking`) caused by subtraction overflow. Co-authored-by: Tuntii <121901995+Tuntii@users.noreply.github.com>
…e-versions-learning-path-7313343372344987490 Update documentation versions and expand learning path 59c1b9a
1 participant
Updates documentation versions to match the current workspace version (0.1.233) and enhances the learning path in the cookbook. Specifically, it updates installation guides, adds a structured internal reading path, provides concrete examples for
rustapi-jobs, and documents theinsightfeature inrustapi-extras.PR created automatically by Jules for task 7313343372344987490 started by @Tuntii