Fix calling memcpy with a null pointer from MatroskaParser#571
Merged
arch1t3cht merged 2 commits intoTypesettingTools:masterfrom Mar 2, 2026
Merged
Fix calling memcpy with a null pointer from MatroskaParser#571arch1t3cht merged 2 commits intoTypesettingTools:masterfrom
memcpy with a null pointer from MatroskaParser#571arch1t3cht merged 2 commits intoTypesettingTools:masterfrom
Conversation
This change was originally authored by mojie126@foxmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #562.
Fix taken from mojie126@42f2aeb. The code seems reasonable to me. Fixing it like this defeats the original purpose of calling the read function with zero size and null buffer, but that original purpose has already been lost anyway because the call just ends up here:
Aegisub/libaegisub/common/file_mapping.cpp
Lines 36 to 37 in 92c9f4c
The purpose appears to be to load the pages into cache. This is not really essential and avoiding UB is more important, but I've added a FIXME to MatroskaParser noting that it doesn't work. I don't really feel like digging deeper into the MatroskaParser code to figure out a better solution.