Conversation
…from base-library dir
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Updated CAN_Init to include heartbeat ID and added heartbeat functionality with TIM7. Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
|
@georgesleen This is a fun PR. So... from the looks of it there are many changes here that are pulled in from the canfd branch. I don't really want to review those here, because those aren't relevant to any of the work you have done. Ideally we could have merged in just the "can.c" and "can.h" files and would not have a PR that is 700,000 lines (something like the command If there isn't a simple solution I also don't want you to worry about this too much. We can always wait to merge the can-library into main, merge those changes here and not worry about it. We love STM32 diffs. |
|
Totally fair, it is a pretty sloppy pr... I'll have a look tomorrow what I can do but I think that the only functional change was to fix all the settings in cubemx and merge the can branch into here. I think this branch had some other can functionality from before so that's why it's hard to get a clean diff on any of the commits. Totally possible I just need to spend a bit of time doing it. |
|
That's fair, it does look like most of the changes are in commit 666565c Although there are still 20,000 other changes... but nicer than 700,000. |
Merge the new CANFD library with a heartbeat to go off every ten seconds, and fix some small things like paths hardcoded for one computer.