Skip to content

Rudder Heartbeat Update#45

Open
georgesleen wants to merge 27 commits intorudder-working-branchfrom
rudder-control-model
Open

Rudder Heartbeat Update#45
georgesleen wants to merge 27 commits intorudder-working-branchfrom
rudder-control-model

Conversation

@georgesleen
Copy link
Copy Markdown
Contributor

Merge the new CANFD library with a heartbeat to go off every ten seconds, and fix some small things like paths hardcoded for one computer.

alisha1697 and others added 27 commits October 25, 2025 12:12
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Updated CAN_Init to include heartbeat ID and added heartbeat functionality with TIM7.

Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
@MichaelGreenough
Copy link
Copy Markdown
Contributor

@georgesleen This is a fun PR. So... from the looks of it there are many changes here that are pulled in from the canfd branch. I don't really want to review those here, because those aren't relevant to any of the work you have done. Ideally we could have merged in just the "can.c" and "can.h" files and would not have a PR that is 700,000 lines (something like the command git checkout can-library -- firmware/com-modules/CANFD/can.c firmware/com-modules/CANFD/can.h). Do you think there is an easy way to retroactively change this easily? (Maybe just deleting the new stuff in this particular branch, it looks like most of the 426 changed files are the new project in firmware/com-modules/library-tests)

If there isn't a simple solution I also don't want you to worry about this too much. We can always wait to merge the can-library into main, merge those changes here and not worry about it.

We love STM32 diffs.

@georgesleen
Copy link
Copy Markdown
Contributor Author

Totally fair, it is a pretty sloppy pr...

I'll have a look tomorrow what I can do but I think that the only functional change was to fix all the settings in cubemx and merge the can branch into here. I think this branch had some other can functionality from before so that's why it's hard to get a clean diff on any of the commits. Totally possible I just need to spend a bit of time doing it.

@MichaelGreenough
Copy link
Copy Markdown
Contributor

That's fair, it does look like most of the changes are in commit 666565c

git diff --shortstat fe564f08dda1cdfef2b83b3d1dbf961a566e5cdc..666565cff45bcab8d2ab124c329f17aa470588bd
 406 files changed, 692109 insertions(+), 25 deletions(-)

Although there are still 20,000 other changes... but nicer than 700,000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants