Skip to content
This repository was archived by the owner on Jan 2, 2024. It is now read-only.

added ability to corrupt wind sensors#264

Draft
jamenkaye wants to merge 8 commits intomasterfrom
BreakWindSensor
Draft

added ability to corrupt wind sensors#264
jamenkaye wants to merge 8 commits intomasterfrom
BreakWindSensor

Conversation

@jamenkaye
Copy link
Copy Markdown
Contributor

  • Should I write more documentation for how to use this code? Should I update the readme document?
  • What is the convention for wind direction angles here? I'm assuming angles need to be on [0, 360) and would need to make a small change otherwise
  • Please let me know if there are any other issues or if I should add something else!

@jamenkaye jamenkaye linked an issue Nov 20, 2021 that may be closed by this pull request
@tylerlum
Copy link
Copy Markdown
Contributor

Should I write more documentation for how to use this code? Should I update the readme document?

  • Good idea, could you update the README with a description of how to use it?

What is the convention for wind direction angles here? I'm assuming angles need to be on [0, 360) and would need to make a small change otherwise

  • I'm not sure if angles are in [0, 360) or [-180, 180). Could you make it work for both or would that be hard?

Comment thread python/MOCK_sensors.py Outdated
@tylerlum
Copy link
Copy Markdown
Contributor

tylerlum commented Nov 23, 2021

Clean way to throttle updates:

rospy.loginfo_throttle(60, "This message will print every 60 seconds")
rospy.logwarn_throttle(60, "This message will print every 60 seconds")

Comment thread python/MOCK_sensors.py
Copy link
Copy Markdown
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes that would make the code cleaner

Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py Outdated
@jamenkaye jamenkaye closed this Dec 2, 2021
@jamenkaye jamenkaye reopened this Dec 2, 2021
Copy link
Copy Markdown
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far, very clean and clear code. Made a couple suggestions

Comment thread README.md Outdated
Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py
Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py Outdated
Addresses feedback from @patrick-5546 to reword 'the chosen wind sensor' to convey that it is randomly selected not chosen.
Comment thread python/MOCK_sensors.py Outdated
patrick-5546
patrick-5546 previously approved these changes Jan 17, 2022
Copy link
Copy Markdown
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR, excited to revisit this once we get some more sensor data

Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py Outdated
Comment thread python/MOCK_sensors.py
Comment thread python/MOCK_sensors.py
Comment thread python/MOCK_sensors.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to corrupt/break sensors

3 participants