Skip to content
This repository was archived by the owner on Jan 2, 2024. It is now read-only.

Separate track made good and heading#272

Open
patrick-5546 wants to merge 5 commits intomasterfrom
mock_track_made_good
Open

Separate track made good and heading#272
patrick-5546 wants to merge 5 commits intomasterfrom
mock_track_made_good

Conversation

@patrick-5546
Copy link
Copy Markdown
Member

Resolves #267

@patrick-5546 patrick-5546 requested a review from tylerlum December 6, 2021 00:48
@patrick-5546
Copy link
Copy Markdown
Member Author

I noticed that the boat often sails up current in this run:

roslaunch local_pathfinding all.launch speedup:=100 ocean_current_speed:=5

Is this to be expected? Does our pathfinding cost function take into account ocean current?

@patrick-5546
Copy link
Copy Markdown
Member Author

patrick-5546 commented Dec 6, 2021

Todo

@tylerlum
Copy link
Copy Markdown
Contributor

Future PR: Consider AIS boats' track_made_good vs heading (which one to use?)

@patrick-5546
Copy link
Copy Markdown
Member Author

Once this is merged in to master, the other CI tests should pass

Copy link
Copy Markdown
Contributor

@jamenkaye jamenkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked on my computer :)

@patrick-5546
Copy link
Copy Markdown
Member Author

Future PR: Consider AIS boats' track_made_good vs heading (which one to use?)

Related issue: #265

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Break apart track_made_good and true_heading

3 participants